Skip to content

Commit 22e96e5

Browse files
committed
fix(AnalyticalTable): show all columns in Dialog
1 parent e98b3ca commit 22e96e5

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

packages/main/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"react-content-loader": "5.1.0",
3939
"react-jss": "10.1.1",
4040
"react-table": "7.5.0",
41-
"react-virtual": "2.2.4"
41+
"react-virtual": "2.2.7"
4242
},
4343
"peerDependencies": {
4444
"@ui5/webcomponents": "1.0.0-rc.9",

packages/main/src/components/AnalyticalTable/index.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -410,9 +410,8 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
410410
if (headerGroup.getHeaderGroupProps) {
411411
headerProps = headerGroup.getHeaderGroupProps();
412412
}
413-
414413
return (
415-
tableRef.current && (
414+
tableRef?.current?.clientWidth > 0 && (
416415
<ColumnHeaderContainer
417416
reactWindowRef={reactWindowRef}
418417
tableRef={tableRef}
@@ -448,7 +447,7 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
448447
{!loading && props.data?.length === 0 && (
449448
<NoDataComponent noDataText={noDataText} className={classes.noDataContainer} style={noDataStyles} />
450449
)}
451-
{props.data?.length > 0 && tableRef.current && (
450+
{props.data?.length > 0 && tableRef?.current?.clientWidth > 0 && (
452451
<VirtualTableBodyContainer
453452
tableBodyHeight={tableBodyHeight}
454453
totalColumnsWidth={totalColumnsWidth}

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16750,10 +16750,10 @@ react-transition-group@^2.5.0:
1675016750
prop-types "^15.6.2"
1675116751
react-lifecycles-compat "^3.0.4"
1675216752

16753-
16754-
version "2.2.4"
16755-
resolved "https://registry.yarnpkg.com/react-virtual/-/react-virtual-2.2.4.tgz#f33c0a8150a7c46e063f0d807f3ad0296c6c6d9f"
16756-
integrity sha512-TOwr7aMozoAzUQvWamSqc+b6ZLY+gtveOnASi2UugIVZ/Vy6b943Vhsp6h7E3pOIVxLv0bpbUUcc/vw9AWj9lw==
16753+
16754+
version "2.2.7"
16755+
resolved "https://registry.yarnpkg.com/react-virtual/-/react-virtual-2.2.7.tgz#01f46e8eb1bfd722edb9a6e01daaef438dd7111f"
16756+
integrity sha512-ggnuqRwYRuuvFdkpD1tOfC5G4nr5xlZUvvp3b/c9r2Nf14dBXZR49oewESyNQnqyO5JT+offgd4oqugLxxdVsQ==
1675716757
dependencies:
1675816758
"@reach/observe-rect" "^1.1.0"
1675916759
ts-toolbelt "^6.4.2"

0 commit comments

Comments
 (0)