cleanup old hook

Author: MarcusNotheis

packages/base/src/hooks/useI18nBundle.ts

@@ -2,25 +2,12 @@ import { fetchI18nBundle, getI18nBundle } from '@ui5/webcomponents-base/dist/i18
 import { useEffect, useState } from 'react';
 
 type TextWithDefault = { key: string; defaultText: string };
+type TextWithPlaceholders = [TextWithDefault, ...string[]];
 
 interface I18nBundle {
   getText: (textObj: TextWithDefault, ...args: any) => string;
 }
 
-export const useI18nBundle = (bundleName): I18nBundle => {
-  const [bundle, setBundle] = useState(getI18nBundle(bundleName));
-
-  useEffect(() => {
-    const fetchAndLoadBundle = async () => {
-      await fetchI18nBundle(bundleName);
-      setBundle(getI18nBundle(bundleName));
-    };
-    fetchAndLoadBundle();
-  }, []);
-
-  return bundle;
-};
-
 const resolveTranslations = (bundle, texts) => {
   return texts.map((text) => {
     if (Array.isArray(text)) {
@@ -31,14 +18,20 @@ const resolveTranslations = (bundle, texts) => {
   });
 };
 
-export const useI18nText = (bundleName: string, ...texts: (TextWithDefault | any[])[]): string[] => {
+export const useI18nText = (bundleName: string, ...texts: (TextWithDefault | TextWithPlaceholders)[]): string[] => {
   const i18nBundle: I18nBundle = getI18nBundle(bundleName);
   const [translations, setTranslations] = useState(resolveTranslations(i18nBundle, texts));
 
   useEffect(() => {
     const fetchAndLoadBundle = async () => {
       await fetchI18nBundle(bundleName);
-      setTranslations(resolveTranslations(i18nBundle, texts));
+      setTranslations((prev) => {
+        const next = resolveTranslations(i18nBundle, texts);
+        if (prev.length === next.length && prev.every((translation, index) => next[index] === translation)) {
+          return prev;
+        }
+        return next;
+      });
     };
     fetchAndLoadBundle();
   }, [fetchI18nBundle]);

packages/base/src/lib/hooks.ts

@@ -1,6 +1,6 @@
 import { useConsolidatedRef } from '../hooks/useConsolidatedRef';
-import { useI18nBundle, useI18nText } from '../hooks/useI18nBundle';
+import { useI18nText } from '../hooks/useI18nBundle';
 import { usePassThroughHtmlProps } from '../hooks/usePassThroughHtmlProps';
 import { useViewportRange } from '../hooks/useViewportRange';
 
-export { useConsolidatedRef, usePassThroughHtmlProps, useViewportRange, useI18nBundle, useI18nText };
+export { useConsolidatedRef, usePassThroughHtmlProps, useViewportRange, useI18nText };