Skip to content

Commit 56df2bb

Browse files
committed
fix(StyleStore): fix stale reference leading to memory leak
1 parent 149cb11 commit 56df2bb

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

packages/base/src/stores/StyleStore.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,13 @@ function getSnapshot(): IStyleStore {
3939

4040
function subscribe(listener: () => void) {
4141
const listeners = getListeners();
42-
STORE_LOCATION[getStyleStoreListenersSymbol()] = [...listeners, listener];
42+
listeners.push(listener);
43+
4344
return () => {
44-
STORE_LOCATION[getStyleStoreListenersSymbol()] = listeners.filter((l) => l !== listener);
45+
const index = listeners.findIndex((l) => l === listener);
46+
if (index >= 0) {
47+
listeners.splice(index, 1);
48+
}
4549
};
4650
}
4751

0 commit comments

Comments
 (0)