Skip to content

Commit 757a097

Browse files
committed
fix: use correct CustomEvent typing when no parameters are available
1 parent a332ec4 commit 757a097

File tree

31 files changed

+57
-50
lines changed

31 files changed

+57
-50
lines changed

packages/main/scripts/create-web-components-wrapper.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,13 @@ const getEventParameters = (parameters) => {
344344

345345
const importStatements = [];
346346

347+
if (resolvedEventParameters.length === 0) {
348+
return {
349+
tsType: `(event: CustomEvent) => void`,
350+
importStatements
351+
};
352+
}
353+
347354
const detailPayload = resolvedEventParameters.map((parameter) => {
348355
if (parameter.importStatement) {
349356
importStatements.push(parameter.importStatement);

packages/main/src/webComponents/Button/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export interface ButtonPropTypes extends Omit<WithWebComponentPropTypes, 'onClic
3333
/**
3434
* Fired when the <code>Button</code> is activated either with a mouse/tap or by using the Enter or Space key. <br><br> <b>Note:</b> The event will not be fired if the <code>disabled</code> property is set to <code>true</code>.
3535
*/
36-
onClick?: (event: CustomEvent<{}>) => void;
36+
onClick?: (event: CustomEvent) => void;
3737
}
3838

3939
/**

packages/main/src/webComponents/Card/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export interface CardPropTypes extends WithWebComponentPropTypes {
3434
/**
3535
* Fired when the <code>Card</code> header is activated by mouse/tap or by using the Enter or Space key. <br><br> <b>Note:</b> The event would be fired only if the <code>headerInteractive</code> property is set to true.
3636
*/
37-
onHeaderClick?: (event: CustomEvent<{}>) => void;
37+
onHeaderClick?: (event: CustomEvent) => void;
3838
}
3939

4040
/**

packages/main/src/webComponents/Carousel/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export interface CarouselPropTypes extends WithWebComponentPropTypes {
4343
/**
4444
* Fired for the last items of the <code>Carousel</code> if it is scrolled and the direction of scrolling is to the end. The number of items for which the event is thrown is controlled by the <code>infiniteScrollOffset</code> property.
4545
*/
46-
onLoadMore?: (event: CustomEvent<{}>) => void;
46+
onLoadMore?: (event: CustomEvent) => void;
4747
/**
4848
* Fired whenever the <code>selectedIndex</code> changes due to user interaction, when the user clicks on the navigation arrows or while resizing, based on the <code>items-per-page-l</code>, <code>items-per-page-m</code> and <code>items-per-page-s</code> properties.
4949
*/

packages/main/src/webComponents/CheckBox/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export interface CheckBoxPropTypes extends Omit<WithWebComponentPropTypes, 'onCh
3939
/**
4040
* Fired when the <code>CheckBox</code> checked state changes.
4141
*/
42-
onChange?: (event: CustomEvent<{}>) => void;
42+
onChange?: (event: CustomEvent) => void;
4343
}
4444

4545
/**

packages/main/src/webComponents/ComboBox/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ export interface ComboBoxPropTypes extends Omit<WithWebComponentPropTypes, 'onCh
4949
/**
5050
* Fired when the input operation has finished by pressing Enter, focusout or an item is selected.
5151
*/
52-
onChange?: (event: CustomEvent<{}>) => void;
52+
onChange?: (event: CustomEvent) => void;
5353
/**
5454
* Fired when typing in input. <br><br> <b>Note:</b> filterValue property is updated, input is changed.
5555
*/
56-
onInput?: (event: CustomEvent<{}>) => void;
56+
onInput?: (event: CustomEvent) => void;
5757
}
5858

5959
/**

packages/main/src/webComponents/CustomListItem/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface CustomListItemPropTypes extends WithWebComponentPropTypes {
1919
/**
2020
* Fired when the user clicks on the detail button when type is <code>Detail</code>.
2121
*/
22-
onDetailClick?: (event: CustomEvent<{}>) => void;
22+
onDetailClick?: (event: CustomEvent) => void;
2323
}
2424

2525
/**

packages/main/src/webComponents/DatePicker/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ export interface DatePickerPropTypes extends Omit<WithWebComponentPropTypes, 'on
6666
/**
6767
* Fired when the input operation has finished by pressing Enter or on focusout.
6868
*/
69-
onChange?: (event: CustomEvent<{}>) => void;
69+
onChange?: (event: CustomEvent) => void;
7070
/**
7171
* Fired when the value of the <code>DatePicker</code> is changed at each key stroke.
7272
*/
73-
onInput?: (event: CustomEvent<{}>) => void;
73+
onInput?: (event: CustomEvent) => void;
7474
}
7575

7676
/**

packages/main/src/webComponents/DateRangePicker/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ export interface DateRangePickerPropTypes extends Omit<WithWebComponentPropTypes
7070
/**
7171
* Fired when the input operation has finished by pressing Enter or on focusout.
7272
*/
73-
onChange?: (event: CustomEvent<{}>) => void;
73+
onChange?: (event: CustomEvent) => void;
7474
/**
7575
* Fired when the value of the <code>DatePicker</code> is changed at each key stroke.
7676
*/
77-
onInput?: (event: CustomEvent<{}>) => void;
77+
onInput?: (event: CustomEvent) => void;
7878
}
7979

8080
/**

packages/main/src/webComponents/DateTimePicker/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ export interface DateTimePickerPropTypes extends Omit<WithWebComponentPropTypes,
6666
/**
6767
* Fired when the input operation has finished by pressing Enter or on focusout.
6868
*/
69-
onChange?: (event: CustomEvent<{}>) => void;
69+
onChange?: (event: CustomEvent) => void;
7070
/**
7171
* Fired when the value of the <code>DatePicker</code> is changed at each key stroke.
7272
*/
73-
onInput?: (event: CustomEvent<{}>) => void;
73+
onInput?: (event: CustomEvent) => void;
7474
}
7575

7676
/**

packages/main/src/webComponents/Dialog/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,19 @@ export interface DialogPropTypes extends WithWebComponentPropTypes {
3434
/**
3535
* Fired after the component is closed. This event does not bubble.
3636
*/
37-
onAfterClose?: (event: CustomEvent<{}>) => void;
37+
onAfterClose?: (event: CustomEvent) => void;
3838
/**
3939
* Fired after the component is opened. This event does not bubble.
4040
*/
41-
onAfterOpen?: (event: CustomEvent<{}>) => void;
41+
onAfterOpen?: (event: CustomEvent) => void;
4242
/**
4343
* Fired before the component is closed. This event can be cancelled, which will prevent the popup from closing. This event does not bubble.
4444
*/
4545
onBeforeClose?: (event: CustomEvent<{ escPressed: boolean }>) => void;
4646
/**
4747
* Fired before the component is opened. This event can be cancelled, which will prevent the popup from opening. This event does not bubble.
4848
*/
49-
onBeforeOpen?: (event: CustomEvent<{}>) => void;
49+
onBeforeOpen?: (event: CustomEvent) => void;
5050
}
5151

5252
/**

packages/main/src/webComponents/DurationPicker/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export interface DurationPickerPropTypes extends Omit<WithWebComponentPropTypes,
4848
/**
4949
* Fired when the input operation has finished by pressing Enter or on focusout.
5050
*/
51-
onChange?: (event: CustomEvent<{}>) => void;
51+
onChange?: (event: CustomEvent) => void;
5252
}
5353

5454
/**

packages/main/src/webComponents/Input/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,15 @@ export interface InputPropTypes extends Omit<WithWebComponentPropTypes, 'onChang
7070
/**
7171
* Fired when the input operation has finished by pressing Enter or on focusout.
7272
*/
73-
onChange?: (event: CustomEvent<{}>) => void;
73+
onChange?: (event: CustomEvent) => void;
7474
/**
7575
* Fired when the value of the <code>Input</code> changes at each keystroke, and when a suggestion item has been selected.
7676
*/
77-
onInput?: (event: CustomEvent<{}>) => void;
77+
onInput?: (event: CustomEvent) => void;
7878
/**
7979
* Fired when user presses Enter key on the <code>Input</code>. <br><br> <b>Note:</b> The event is fired independent of whether there was a change before or not. If change was performed, the event is fired after the change event. The event is also fired when an item of the select list is selected by pressing Enter.
8080
*/
81-
onSubmit?: (event: CustomEvent<{}>) => void;
81+
onSubmit?: (event: CustomEvent) => void;
8282
/**
8383
* Fired when the user navigates to a suggestion item via the ARROW keys, as a preview, before the final selection.
8484
*/

packages/main/src/webComponents/Link/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export interface LinkPropTypes extends Omit<WithWebComponentPropTypes, 'onClick'
3131
/**
3232
* Fired when the <code>Link</code> is triggered either with a mouse/tap or by using the Enter key.
3333
*/
34-
onClick?: (event: CustomEvent<{}>) => void;
34+
onClick?: (event: CustomEvent) => void;
3535
}
3636

3737
/**

packages/main/src/webComponents/List/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export interface ListPropTypes extends WithWebComponentPropTypes {
6464
/**
6565
* Fired when the user scrolls to the bottom of the list. <br><br> <b>Note:</b> The event is fired when the <code>infiniteScroll</code> property is enabled.
6666
*/
67-
onLoadMore?: (event: CustomEvent<{}>) => void;
67+
onLoadMore?: (event: CustomEvent) => void;
6868
/**
6969
* Fired when selection is changed by user interaction in <code>SingleSelect</code>, <code>SingleSelectBegin</code>, <code>SingleSelectEnd</code> and <code>MultiSelect</code> modes.
7070
*/

packages/main/src/webComponents/MessageStrip/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export interface MessageStripPropTypes extends WithWebComponentPropTypes {
2929
/**
3030
* Fired when the close button is pressed either with a click/tap or by using the Enter or Space key.
3131
*/
32-
onClose?: (event: CustomEvent<{}>) => void;
32+
onClose?: (event: CustomEvent) => void;
3333
}
3434

3535
/**

packages/main/src/webComponents/MultiComboBox/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,15 @@ export interface MultiComboBoxPropTypes extends Omit<WithWebComponentPropTypes,
4343
/**
4444
* Fired when the input operation has finished by pressing Enter or on focusout.
4545
*/
46-
onChange?: (event: CustomEvent<{}>) => void;
46+
onChange?: (event: CustomEvent) => void;
4747
/**
4848
* Fired when the value of the <code>MultiComboBox</code> changes at each keystroke.
4949
*/
50-
onInput?: (event: CustomEvent<{}>) => void;
50+
onInput?: (event: CustomEvent) => void;
5151
/**
5252
* Fired when the dropdown is opened or closed.
5353
*/
54-
onOpenChange?: (event: CustomEvent<{}>) => void;
54+
onOpenChange?: (event: CustomEvent) => void;
5555
/**
5656
* Fired when selection is changed by user interaction in <code>SingleSelect</code> and <code>MultiSelect</code> modes.
5757
*/

packages/main/src/webComponents/NotificationListGroupItem/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ export interface NotificationListGroupItemPropTypes extends WithWebComponentProp
4343
/**
4444
* Fired when the <code>NotificationListGroupItem</code> is expanded/collapsed by user interaction.
4545
*/
46-
onToggle?: (event: CustomEvent<{}>) => void;
46+
onToggle?: (event: CustomEvent) => void;
4747
/**
4848
* Fired when the <code>Close</code> button is pressed.
4949
*/
50-
onClose?: (event: CustomEvent<{}>) => void;
50+
onClose?: (event: CustomEvent) => void;
5151
}
5252

5353
/**

packages/main/src/webComponents/NotificationListItem/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export interface NotificationListItemPropTypes extends WithWebComponentPropTypes
5757
/**
5858
* Fired when the <code>Close</code> button is pressed.
5959
*/
60-
onClose?: (event: CustomEvent<{}>) => void;
60+
onClose?: (event: CustomEvent) => void;
6161
}
6262

6363
/**

packages/main/src/webComponents/Popover/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,19 @@ export interface PopoverPropTypes extends WithWebComponentPropTypes {
5757
/**
5858
* Fired after the component is closed. This event does not bubble.
5959
*/
60-
onAfterClose?: (event: CustomEvent<{}>) => void;
60+
onAfterClose?: (event: CustomEvent) => void;
6161
/**
6262
* Fired after the component is opened. This event does not bubble.
6363
*/
64-
onAfterOpen?: (event: CustomEvent<{}>) => void;
64+
onAfterOpen?: (event: CustomEvent) => void;
6565
/**
6666
* Fired before the component is closed. This event can be cancelled, which will prevent the popup from closing. This event does not bubble.
6767
*/
6868
onBeforeClose?: (event: CustomEvent<{ escPressed: boolean }>) => void;
6969
/**
7070
* Fired before the component is opened. This event can be cancelled, which will prevent the popup from opening. This event does not bubble.
7171
*/
72-
onBeforeOpen?: (event: CustomEvent<{}>) => void;
72+
onBeforeOpen?: (event: CustomEvent) => void;
7373
}
7474

7575
/**

packages/main/src/webComponents/ProductSwitchItem/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export interface ProductSwitchItemPropTypes extends Omit<WithWebComponentPropTyp
2828
/**
2929
* Fired when the <code>ProductSwitchItem</code> is activated either with a click/tap or by using the Enter or Space key.
3030
*/
31-
onClick?: (event: CustomEvent<{}>) => void;
31+
onClick?: (event: CustomEvent) => void;
3232
}
3333

3434
/**

packages/main/src/webComponents/RadioButton/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export interface RadioButtonPropTypes extends Omit<WithWebComponentPropTypes, 'o
4747
/**
4848
* Fired when the <code>RadioButton</code> selected state changes.
4949
*/
50-
onSelect?: (event: CustomEvent<{}>) => void;
50+
onSelect?: (event: CustomEvent) => void;
5151
}
5252

5353
/**

packages/main/src/webComponents/RatingIndicator/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export interface RatingIndicatorPropTypes extends Omit<WithWebComponentPropTypes
2424
/**
2525
* The event is fired when the value changes.
2626
*/
27-
onChange?: (event: CustomEvent<{}>) => void;
27+
onChange?: (event: CustomEvent) => void;
2828
}
2929

3030
/**

packages/main/src/webComponents/ResponsivePopover/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,19 @@ export interface ResponsivePopoverPropTypes extends WithWebComponentPropTypes {
5757
/**
5858
* Fired after the component is closed. This event does not bubble.
5959
*/
60-
onAfterClose?: (event: CustomEvent<{}>) => void;
60+
onAfterClose?: (event: CustomEvent) => void;
6161
/**
6262
* Fired after the component is opened. This event does not bubble.
6363
*/
64-
onAfterOpen?: (event: CustomEvent<{}>) => void;
64+
onAfterOpen?: (event: CustomEvent) => void;
6565
/**
6666
* Fired before the component is closed. This event can be cancelled, which will prevent the popup from closing. This event does not bubble.
6767
*/
6868
onBeforeClose?: (event: CustomEvent<{ escPressed: boolean }>) => void;
6969
/**
7070
* Fired before the component is opened. This event can be cancelled, which will prevent the popup from opening. This event does not bubble.
7171
*/
72-
onBeforeOpen?: (event: CustomEvent<{}>) => void;
72+
onBeforeOpen?: (event: CustomEvent) => void;
7373
}
7474

7575
/**

packages/main/src/webComponents/StandardListItem/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export interface StandardListItemPropTypes extends WithWebComponentPropTypes {
4444
/**
4545
* Fired when the user clicks on the detail button when type is <code>Detail</code>.
4646
*/
47-
onDetailClick?: (event: CustomEvent<{}>) => void;
47+
onDetailClick?: (event: CustomEvent) => void;
4848
}
4949

5050
/**

packages/main/src/webComponents/Switch/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export interface SwitchPropTypes extends Omit<WithWebComponentPropTypes, 'onChan
2828
/**
2929
* Fired when the <code>Switch</code> checked state changes.
3030
*/
31-
onChange?: (event: CustomEvent<{}>) => void;
31+
onChange?: (event: CustomEvent) => void;
3232
}
3333

3434
/**

packages/main/src/webComponents/TextArea/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ export interface TextAreaPropTypes extends Omit<WithWebComponentPropTypes, 'onCh
6767
/**
6868
* Fired when the text has changed and the focus leaves the <code>TextArea</code>.
6969
*/
70-
onChange?: (event: CustomEvent<{}>) => void;
70+
onChange?: (event: CustomEvent) => void;
7171
/**
7272
* Fired when the value of the <code>TextArea</code> changes at each keystroke or when something is pasted.
7373
*/
74-
onInput?: (event: CustomEvent<{}>) => void;
74+
onInput?: (event: CustomEvent) => void;
7575
}
7676

7777
/**

packages/main/src/webComponents/TimePicker/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ export interface TimePickerPropTypes extends Omit<WithWebComponentPropTypes, 'on
4141
/**
4242
* Fired when the input operation has finished by clicking the "OK" button or when the text in the input field has changed and the focus leaves the input field.
4343
*/
44-
onChange?: (event: CustomEvent<{}>) => void;
44+
onChange?: (event: CustomEvent) => void;
4545
/**
4646
* Fired when the value of the <code>TimePicker</code> is changed at each key stroke.
4747
*/
48-
onInput?: (event: CustomEvent<{}>) => void;
48+
onInput?: (event: CustomEvent) => void;
4949
}
5050

5151
/**

packages/main/src/webComponents/TimelineItem/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export interface TimelineItemPropTypes extends WithWebComponentPropTypes {
3232
/**
3333
* Fired when the item name is pressed either with a click/tap or by using the Enter or Space key. <br><br> <b>Note:</b> The event will not be fired if the <code>item-name-clickable</code> attribute is not set.
3434
*/
35-
onItemNameClick?: (event: CustomEvent<{}>) => void;
35+
onItemNameClick?: (event: CustomEvent) => void;
3636
}
3737

3838
/**

packages/main/src/webComponents/ToggleButton/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export interface ToggleButtonPropTypes extends Omit<WithWebComponentPropTypes, '
3939
/**
4040
* Fired when the <code>Button</code> is activated either with a mouse/tap or by using the Enter or Space key. <br><br> <b>Note:</b> The event will not be fired if the <code>disabled</code> property is set to <code>true</code>.
4141
*/
42-
onClick?: (event: CustomEvent<{}>) => void;
42+
onClick?: (event: CustomEvent) => void;
4343
}
4444

4545
/**

packages/main/src/webComponents/UploadCollectionItem/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,19 @@ export interface UploadCollectionItemPropTypes extends WithWebComponentPropTypes
4747
/**
4848
* Fired when the file name is clicked. <br><br> <b>Note:</b> This event is only available when <code>fileNameClickable</code> property is <code>true</code>.
4949
*/
50-
onFileNameClick?: (event: CustomEvent<{}>) => void;
50+
onFileNameClick?: (event: CustomEvent) => void;
5151
/**
5252
* Fired when the <code>fileName</code> property gets changed. <br><br> <b>Note:</b> An edit button is displayed on each item, when the <code>UploadCollectionItem</code> <code>type</code> property is set to <code>Detail</code>.
5353
*/
54-
onRename?: (event: CustomEvent<{}>) => void;
54+
onRename?: (event: CustomEvent) => void;
5555
/**
5656
* Fired when the retry button is pressed. <br><br> <b>Note:</b> Retry button is displayed when <code>uploadState</code> property is set to <code>Error</code>.
5757
*/
58-
onRetry?: (event: CustomEvent<{}>) => void;
58+
onRetry?: (event: CustomEvent) => void;
5959
/**
6060
* Fired when the terminate button is pressed. <br><br> <b>Note:</b> Terminate button is displayed when <code>uploadState</code> property is set to <code>Uploading</code>.
6161
*/
62-
onTerminate?: (event: CustomEvent<{}>) => void;
62+
onTerminate?: (event: CustomEvent) => void;
6363
}
6464

6565
/**

0 commit comments

Comments
 (0)