Skip to content

Commit 7a46973

Browse files
authored
docs: remove Portals knowledge base entry (#6231)
1 parent 5432744 commit 7a46973

File tree

3 files changed

+1
-86
lines changed

3 files changed

+1
-86
lines changed

docs/knowledge-base/FAQ.mdx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ import { MessageStrip } from '@ui5/webcomponents-react';
2424
<br />
2525
<br />
2626

27-
## Why is my Popover, Dialog, etc. not rendered correctly?
28-
29-
Mounting popups, like the Popover, inside of components can lead to unwanted side-effects (wrong positioning, alignment, etc.), to prevent that we recommend either mounting it outside of the component, or mounting it with a React portal.
30-
You can find out more about how we use portals [here](?path=/docs/knowledge-base-working-with-portals--docs).
31-
3227
## Where can I find all compatible versions of `@ui5/webcomponents` and `@ui5/webcomponents-react`?
3328

3429
All necessary `@ui5/webcomponents` packages are `peerDependencies` of `@ui5/webcomponents-react`, so if you're using npm v7 or later, then these dependencies should be auto installed when running `npm install`.

docs/knowledge-base/Portals.mdx

Lines changed: 0 additions & 80 deletions
This file was deleted.

packages/compat/src/components/Toolbar/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export interface ToolbarPropTypes extends Omit<CommonProps, 'onClick' | 'childre
7070
/**
7171
* Defines where modals are rendered into via `React.createPortal`.
7272
*
73-
* You can find out more about this [here](https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/knowledge-base-working-with-portals--page).
73+
* You can find out more about this [here](https://sap.github.io/ui5-webcomponents-react/v1/?path=/docs/knowledge-base-working-with-portals--page).
7474
*
7575
* Defaults to: `document.body`
7676
*/

0 commit comments

Comments
 (0)