Skip to content

Commit 8b01af4

Browse files
authored
fix(VariantManagement): apply correct header size for "Manage Views" dialog (#6185)
1 parent de68b2d commit 8b01af4

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

packages/main/src/components/ThemeProvider/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ const InternalUI5WCVVarNames = {
2222
'--_ui5wcr_card_header_focus_border': `var(${getScopedVarName('--_ui5_card_header_focus_border')})`,
2323
'--_ui5wcr_card_header_focus_radius': `var(${getScopedVarName('--_ui5_card_header_focus_radius')})`,
2424
'--_ui5wcr_card_header_focus_bottom_radius': `var(${getScopedVarName('--_ui5_card_header_focus_bottom_radius')})`,
25-
'--_ui5wcr_popup_header_font_family': `var(${getScopedVarName('--_ui5_popup_header_font_family')})`,
26-
'--_ui5wcr_popup_default_header_height': `var(${getScopedVarName('--_ui5_popup_default_header_height')})`
25+
'--_ui5wcr_popup_header_font_family': `var(${getScopedVarName('--_ui5_popup_header_font_family')})`
2726
};
2827

2928
const ui5WcVariablesStyleData: StyleDataCSP = {

packages/main/src/components/VariantManagement/ManageViewsDialog.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import BarDesign from '@ui5/webcomponents/dist/types/BarDesign.js';
22
import ButtonDesign from '@ui5/webcomponents/dist/types/ButtonDesign.js';
33
import TableOverflowMode from '@ui5/webcomponents/dist/types/TableOverflowMode.js';
4+
import { getScopedVarName } from '@ui5/webcomponents-base/dist/CustomElementsScope.js';
45
import searchIcon from '@ui5/webcomponents-icons/dist/search.js';
56
import { enrichEventWithDetails, useI18nBundle, useStylesheet } from '@ui5/webcomponents-react-base';
67
import type { MouseEventHandler, ReactElement } from 'react';
@@ -17,6 +18,7 @@ import {
1718
SHARING,
1819
VIEW
1920
} from '../../i18n/i18n-defaults.js';
21+
import type { CommonProps } from '../../types/CommonProps.js';
2022
import { Bar } from '../../webComponents/Bar/index.js';
2123
import { Button } from '../../webComponents/Button/index.js';
2224
import type { DialogPropTypes } from '../../webComponents/Dialog/index.js';
@@ -223,6 +225,11 @@ export const ManageViewsDialog = (props: ManageViewsDialogPropTypes) => {
223225
onBeforeClose={handleClose}
224226
headerText={manageViewsText}
225227
initialFocus={`search-${uniqueId}`}
228+
style={
229+
{
230+
'--_ui5wcr_popup_default_header_height': `var(${getScopedVarName('--_ui5_popup_default_header_height')})`
231+
} as CommonProps['style'] & { '--_ui5wcr_popup_default_header_height': string }
232+
}
226233
header={
227234
<FlexBox direction={FlexBoxDirection.Column} style={{ width: '100%' }} alignItems={FlexBoxAlignItems.Center}>
228235
<h2 className={classNames.headerText}>{manageViewsText}</h2>

0 commit comments

Comments
 (0)