Skip to content

Commit 9bf94d6

Browse files
fix(AnalyticalTable): add missing keys (#808)
1 parent 5a4e8f5 commit 9bf94d6

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

packages/main/src/components/AnalyticalTable/ColumnHeader/ColumnHeaderContainer.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { ThemingParameters } from '@ui5/webcomponents-react-base/lib/ThemingParameters';
2-
import React, { useCallback } from 'react';
2+
import React, { Fragment, useCallback } from 'react';
33
import { createUseStyles } from 'react-jss';
44
import { useVirtual, VirtualItem } from 'react-virtual';
55
import { ColumnHeader } from './index';
@@ -71,8 +71,10 @@ export const ColumnHeaderContainer = (props) => {
7171
return null;
7272
}
7373
const isLastColumn = !column.disableResizing && virtualColumn.index + 1 === headerGroup.headers.length;
74+
75+
const { key, ...rest } = column.getHeaderProps();
7476
return (
75-
<>
77+
<Fragment key={key}>
7678
{column.canResize && column.getResizerProps && (
7779
<div
7880
{...column.getResizerProps()}
@@ -82,7 +84,7 @@ export const ColumnHeaderContainer = (props) => {
8284
/>
8385
)}
8486
<ColumnHeader
85-
{...column.getHeaderProps()}
87+
{...rest}
8688
onSort={onSort}
8789
onGroupBy={onGroupByChanged}
8890
onDragStart={onDragStart}
@@ -97,7 +99,7 @@ export const ColumnHeaderContainer = (props) => {
9799
>
98100
{column.render('Header')}
99101
</ColumnHeader>
100-
</>
102+
</Fragment>
101103
);
102104
})}
103105
</div>

packages/main/src/components/AnalyticalTable/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,14 +441,15 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
441441
>
442442
<div className={classes.tableHeaderBackgroundElement} />
443443
{headerGroups.map((headerGroup) => {
444-
let headerProps = {};
444+
let headerProps: Record<string, unknown> = {};
445445
if (headerGroup.getHeaderGroupProps) {
446446
headerProps = headerGroup.getHeaderGroupProps();
447447
}
448448

449449
return (
450450
tableRef.current && (
451451
<ColumnHeaderContainer
452+
key={headerProps.key}
452453
reactWindowRef={reactWindowRef}
453454
tableRef={tableRef}
454455
resizeInfo={tableState.columnResizing}

0 commit comments

Comments
 (0)