Skip to content

Commit e0699d8

Browse files
fix(ComposedChart): fix onDataPointClick event payload for bars (#3697)
1 parent 2fe8757 commit e0699d8

File tree

1 file changed

+7
-5
lines changed
  • packages/charts/src/components/ComposedChart

1 file changed

+7
-5
lines changed

packages/charts/src/components/ComposedChart/index.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,12 @@ const ComposedChart: FC<ComposedChartProps> = forwardRef((props: ComposedChartPr
204204

205205
const onDataPointClickInternal = (payload, eventOrIndex, event) => {
206206
if (typeof onDataPointClick === 'function') {
207-
if (payload.name) {
208-
const payloadValueLength = payload?.value?.length;
207+
if (typeof eventOrIndex === 'number') {
208+
const payloadValueLength = Array.isArray(payload?.value);
209209
onDataPointClick(
210-
enrichEventWithDetails(event ?? eventOrIndex, {
210+
enrichEventWithDetails(event, {
211211
value: payloadValueLength ? payload.value[1] - payload.value[0] : payload.value,
212-
dataIndex: payload.index ?? typeof eventOrIndex === 'number' ? eventOrIndex : undefined,
212+
dataIndex: payload.index ?? eventOrIndex,
213213
dataKey: payloadValueLength
214214
? Object.keys(payload).filter((key) =>
215215
payload.value.length
@@ -224,7 +224,9 @@ const ComposedChart: FC<ComposedChartProps> = forwardRef((props: ComposedChartPr
224224
} else {
225225
onDataPointClick(
226226
enrichEventWithDetails({} as any, {
227-
value: eventOrIndex.value,
227+
value: Array.isArray(eventOrIndex.value)
228+
? eventOrIndex.value[1] - eventOrIndex.value[0]
229+
: eventOrIndex.value,
228230
dataKey: eventOrIndex.dataKey,
229231
dataIndex: eventOrIndex.index,
230232
payload: eventOrIndex.payload

0 commit comments

Comments
 (0)