Skip to content

Commit e3b1117

Browse files
authored
fix(AnalyticalTable): prevent crash if unsupported rowId is set as selectedRowIds key (#660)
1 parent 44bedf8 commit e3b1117

File tree

1 file changed

+7
-2
lines changed
  • packages/main/src/components/AnalyticalTable

1 file changed

+7
-2
lines changed

packages/main/src/components/AnalyticalTable/index.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,11 +282,16 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
282282

283283
useEffect(() => {
284284
toggleAllRowsSelected(false);
285+
const validChars = /^(\d\.)*\d$/;
285286
// eslint-disable-next-line guard-for-in
286287
for (const row in selectedRowIds) {
287-
toggleRowSelected(row, selectedRowIds[row]);
288+
if (reactTableOptions?.getRowId) {
289+
toggleRowSelected(row, selectedRowIds[row]);
290+
} else if (validChars.test(row)) {
291+
toggleRowSelected(row, selectedRowIds[row]);
292+
}
288293
}
289-
}, [toggleRowSelected, toggleAllRowsSelected, selectedRowIds]);
294+
}, [toggleRowSelected, toggleAllRowsSelected, selectedRowIds, reactTableOptions?.getRowId]);
290295

291296
const calcRowHeight = parseInt(
292297
getComputedStyle(tableRef.current ?? document.body).getPropertyValue('--sapWcrAnalyticalTableRowHeight') || '44'

0 commit comments

Comments
 (0)