Skip to content

Commit e6d9322

Browse files
Merge branch 'master' into fix/popovers-bubbling
2 parents 8d24157 + ff287cf commit e6d9322

File tree

5 files changed

+8
-17
lines changed

5 files changed

+8
-17
lines changed

packages/main/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"lodash.debounce": "^4.0.8",
3737
"react-content-loader": "5.1.0",
3838
"react-jss": "10.1.1",
39-
"react-table": "7.2.2",
39+
"react-table": "7.3.2",
4040
"react-virtual": "2.2.1"
4141
},
4242
"peerDependencies": {

packages/main/src/components/AnalyticalTable/AnalyticalTable.stories.mdx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ import { FlexBoxJustifyContent } from '@ui5/webcomponents-react/lib/FlexBoxJusti
8585
}
8686
],
8787
title: 'Table Title',
88-
busyIndicatorEnabled: true,
8988
sortable: true,
9089
filterable: true,
9190
visibleRows: 15,
@@ -135,7 +134,6 @@ import { FlexBoxJustifyContent } from '@ui5/webcomponents-react/lib/FlexBoxJusti
135134
data={args.data}
136135
columns={args.columns}
137136
loading={args.loading}
138-
busyIndicatorEnabled={args.busyIndicatorEnabled}
139137
alternateRowColor={args.alternateRowColor}
140138
sortable={args.sortable}
141139
filterable={args.filterable}
@@ -283,7 +281,6 @@ This even works if you resize the browser window!
283281
data={args.dataTree}
284282
columns={args.columns}
285283
loading={args.loading}
286-
busyIndicatorEnabled={args.busyIndicatorEnabled}
287284
sortable={args.sortable}
288285
filterable={args.filterable}
289286
visibleRows={args.visibleRows}

packages/main/src/components/AnalyticalTable/AnalyticalTable.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ describe('AnalyticalTable', () => {
169169
data={dataTree}
170170
columns={columns}
171171
loading={false}
172-
busyIndicatorEnabled={true}
173172
sortable={true}
174173
filterable={true}
175174
visibleRows={15}

packages/main/src/components/AnalyticalTable/index.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ export interface TableProps extends CommonProps {
7272
minRows?: number;
7373
visibleRows?: number;
7474
loading?: boolean;
75-
busyIndicatorEnabled?: boolean;
7675
noDataText?: string;
7776
rowHeight?: number;
7877
alternateRowColor?: boolean;
@@ -143,7 +142,6 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
143142
onSort,
144143
reactTableOptions,
145144
tableHooks,
146-
busyIndicatorEnabled,
147145
subRowsKey,
148146
onGroup,
149147
rowHeight,
@@ -227,8 +225,8 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
227225
...reactTableOptions
228226
},
229227
useFilters,
230-
useGroupBy,
231228
useColumnOrder,
229+
useGroupBy,
232230
useSortBy,
233231
useExpanded,
234232
useRowSelect,
@@ -403,9 +401,7 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
403401
</header>
404402
);
405403
})}
406-
{loading && busyIndicatorEnabled && props.data?.length > 0 && (
407-
<LoadingComponent style={{ width: `${totalColumnsWidth}px` }} />
408-
)}
404+
{loading && props.data?.length > 0 && <LoadingComponent style={{ width: `${totalColumnsWidth}px` }} />}
409405
{loading && props.data?.length === 0 && (
410406
<TablePlaceholder
411407
columns={tableInternalColumns.filter(
@@ -448,7 +444,6 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
448444
AnalyticalTable.displayName = 'AnalyticalTable';
449445
AnalyticalTable.defaultProps = {
450446
loading: false,
451-
busyIndicatorEnabled: true,
452447
sortable: true,
453448
filterable: false,
454449
groupable: false,

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4481,7 +4481,7 @@
44814481
dependencies:
44824482
"@types/react" "*"
44834483

4484-
"@types/react@*", "@types/react@16.9.34", "@types/react@^16.9.34":
4484+
"@types/react@*", "@types/react@^16.9.34":
44854485
version "16.9.34"
44864486
resolved "https://registry.yarnpkg.com/@types/react/-/react-16.9.34.tgz#f7d5e331c468f53affed17a8a4d488cd44ea9349"
44874487
integrity sha512-8AJlYMOfPe1KGLKyHpflCg5z46n0b5DbRfqDksxBLBTUpB75ypDBAO9eCUcjNwE6LCUslwTz00yyG/X9gaVtow==
@@ -16870,10 +16870,10 @@ react-syntax-highlighter@^12.2.1:
1687016870
prismjs "^1.8.4"
1687116871
refractor "^2.4.1"
1687216872

16873-
react-table@7.2.2:
16874-
version "7.2.2"
16875-
resolved "https://registry.yarnpkg.com/react-table/-/react-table-7.2.2.tgz#2978a903f0e367e1ceab25d60a6a40ae23498f77"
16876-
integrity sha512-JBE3QUyRQJkHRU72NKo7HRGtSGcrzIcVLDbsoZI+KhWkFEZ2t9UfpqeHBdbc3R5RRJZ6qC7+NzZZxJPSYWKPBQ==
16873+
react-table@7.3.2:
16874+
version "7.3.2"
16875+
resolved "https://registry.yarnpkg.com/react-table/-/react-table-7.3.2.tgz#def43b9777e0ef5839608104a557c3f1c365b2ff"
16876+
integrity sha512-n8ZvC8tzuDa3qK9PFlcXmo58JCRfxg/3LlvG8YJywvsQKiCnTfK6lDSp8a3WsAOBcZvBtGgyeoke7pBfAdB8jA==
1687716877

1687816878
react-test-renderer@^16.0.0-0:
1687916879
version "16.13.1"

0 commit comments

Comments
 (0)