fix(Variant Management): fix error message for duplicate variant names (#4498)

fixes #4496

Author: MarcusNotheis

packages/main/src/components/VariantManagement/ManageViewsTableRows.tsx

@@ -7,7 +7,7 @@ import { ButtonDesign, ValueState } from '../../enums';
 import {
   APPLY_AUTOMATICALLY,
   DELETE_VIEW,
-  FILE_ALREADY_EXISTS,
+  VARIANT_MANAGEMENT_ERROR_DUPLICATE,
   MARK_AS_FAVORITE,
   MARK_AS_STANDARD,
   PRIVATE,
@@ -64,7 +64,7 @@ export const ManageViewsTableRows = (props: ManageViewsTableRowsProps) => {
   } = props;
 
   const i18nBundle = useI18nBundle('@ui5/webcomponents-react');
-  const errorTextAlreadyExists = i18nBundle.getText(FILE_ALREADY_EXISTS);
+  const errorTextAlreadyExists = i18nBundle.getText(VARIANT_MANAGEMENT_ERROR_DUPLICATE);
   const errorTextEmpty = i18nBundle.getText(SPECIFY_VIEW_NAME);
   const publicText = i18nBundle.getText(PUBLIC);
   const privateText = i18nBundle.getText(PRIVATE);

packages/main/src/components/VariantManagement/SaveViewDialog.tsx

@@ -7,7 +7,7 @@ import { BarDesign, ButtonDesign, FlexBoxAlignItems, FlexBoxDirection } from '..
 import {
   APPLY_AUTOMATICALLY,
   CANCEL,
-  FILE_ALREADY_EXISTS,
+  VARIANT_MANAGEMENT_ERROR_DUPLICATE,
   PUBLIC,
   SAVE,
   SAVE_VIEW,
@@ -83,7 +83,7 @@ export const SaveViewDialog = (props: SaveViewDialogPropTypes) => {
   const publicCbLabel = i18nBundle.getText(PUBLIC);
   const applyAutomaticallyCbLabel = i18nBundle.getText(APPLY_AUTOMATICALLY);
   const inputLabelText = i18nBundle.getText(VIEW);
-  const errorTextAlreadyExists = i18nBundle.getText(FILE_ALREADY_EXISTS);
+  const errorTextAlreadyExists = i18nBundle.getText(VARIANT_MANAGEMENT_ERROR_DUPLICATE);
   const errorTextEmpty = i18nBundle.getText(SPECIFY_VIEW_NAME);
 
   const [isDefault, setDefault] = useState(selectedVariant.isDefault);

packages/main/src/components/VariantManagement/VariantManagement.cy.tsx

@@ -347,7 +347,7 @@ describe('VariantManagement', () => {
     cy.findByText('Please specify a view name');
     cy.get('[ui5-input]').typeIntoUi5Input('VariantItem 1');
     cy.get('[ui5-input]').should('have.attr', 'value-state', 'Error');
-    cy.findByText('A file with this name already exists');
+    cy.findByText('The view name already exists. Please enter a different name.');
 
     // valid entries & save
     cy.get('[ui5-input]').typeIntoUi5Input('{selectall}{backspace}Updated!');

packages/main/src/i18n/messagebundle.properties

@@ -153,8 +153,8 @@ MANAGE_VIEWS=Manage Views
 #XFLD: Label for the VariantManagement Save View dialog input field
 VIEW=View
 
-#XMSG: Error message if the same variant name was used.
-FILE_ALREADY_EXISTS=A file with this name already exists
+#XTIT: VariantManagement predefined title for Error Message duplicate Variant
+VARIANT_MANAGEMENT_ERROR_DUPLICATE=The view name already exists. Please enter a different name.
 
 #XMSG: Error message if the variant name is left empty
 SPECIFY_VIEW_NAME=Please specify a view name