Skip to content

Commit f5361c0

Browse files
authored
fix: omit html attributes from web components if value is false (#4941)
Fixes #4937
1 parent ee02c63 commit f5361c0

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

packages/main/src/internal/withWebComponent.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,13 @@ export const withWebComponent = <Props extends Record<string, any>, RefType = Ui
135135
.filter(([key]) => !slotProperties.includes(key))
136136
.filter(([key]) => !booleanProperties.includes(key))
137137
.filter(([key]) => !eventProperties.map((eventName) => createEventPropName(eventName)).includes(key))
138-
.reduce((acc, [key, val]) => ({ ...acc, [key]: val }), {});
138+
.reduce((acc, [key, val]) => {
139+
if (!key.startsWith('aria-') && !key.startsWith('data-') && val === false) {
140+
return acc;
141+
}
142+
acc[key] = val;
143+
return acc;
144+
}, {});
139145

140146
useEffect(() => {
141147
if (waitForDefine && !isDefined) {

0 commit comments

Comments
 (0)