-
Notifications
You must be signed in to change notification settings - Fork 103
[Object Page]: Accessibility issue: contentinfo landmark should not be contained in another landmark #7173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @bomasap I wasn't able to reproduce the issue with Axe DevTools v4.10.3. Also, I wasn't able to find an element with the |
Hi @Lukas742 Thanks for your comment. You need to turn "Best Practices" Toggle on in Axe DevTools. |
I did: Also, please keep in mind that this is only an example. While it should be in general accessible, it doesn't mean complex components that implement other components which may require setting accessible attributes manually, lives up to app standards. So, if an accessibility issue is found in one of our examples, we will gladly fix it, but for this the example needs to be isolated (meaning it should only use the components required to reproduce the issue).
contribution guidelines for a11y |
Hi Luaks, Thank you for your reply. I’ve identified the root cause of the issue — the Chrome browser automatically adds However, there's still another accessibility issue related to the UI5 Web Components. When the If we need to remove role="main" from the FlexibleColumnLayout, could you advise where we should assign the role="main" instead? I’ve also updated the isolation example — please take a look. https://stackblitz.com/edit/github-t5j5mn-2urftkct?file=src%2FApp.tsx,package.json https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/contentinfo.html ![]() ![]() |
Hi @bomasap
I'm not aware that this is enabled by Chrome per default, since using heuristics for accessibility, such as inferring landmark roles based on an element’s id, is unreliable. Heuristics depend on assumptions that may vary between tools and browsers, leading to inconsistent behavior. Is this also happening when disabling all plugins you have installed and outside of AXE Dev tools?
I drilled down the issue to it's core and you're right, here you can find a minimal reproducible example that shows the issue: https://stackblitz.com/edit/github-t5j5mn-pd4sm2rp?file=src%2FApp.tsx,package.json I find it strange that Axe DevTools only reports an issue if
|
Hi @Lukas742 Thank you for providing the ability to resolve the |
🎉 This issue has been resolved in version v2.9.0 🎉 The release is available on v2.9.0 Your semantic-release bot 📦🚀 |
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
While running Axe DevTools, we encountered the following accessibility issue:
Root Cause:
In the current HTML structure:
The
<div id="content">
is explicitly assignedrole="main"
anddata-landmark-guessed
, which signals to accessibility tools that it serves as a main landmark.As a result, the
<footer>
element (which defines a contentinfo landmark by default) becomes a descendant of the main landmark, which violates WAI-ARIA landmark roles rules.Isolated Example
https://stackblitz.com/edit/github-t5j5mn-2urftkct?file=src%2FApp.tsx,package.json
Reproduction steps
Expected Behaviour
No response
Screenshots or Videos
UI5 Web Components for React Version
2.7.2
UI5 Web Components Version
2.7.0
Browser
Safari, Chrome, Edge, Firefox
Operating System
No response
Additional Context
No response
Relevant log output
Organization
No response
Declaration
The text was updated successfully, but these errors were encountered: