refactor(Device): deprecate Device class and move all methods to smaller util functions #697

MarcusNotheis · 2020-10-01T07:17:36Z

This PR deprecates the Device class and splits its functionality into smaller, reusable utility functions (similar to the UI5 Web Components Device). There is no breaking change for now, but I plan to remove the Device in v0.12.0.

This will be very useful for #194 as well.

github-actions · 2020-10-01T07:21:46Z

Size Change: +4.16 kB (2%)

Total Size: 162 kB

Filename	Size	Change
`packages/base/lib/Device.js`	6.82 kB	+351 B (5%)	🔍
`packages/base/lib/hooks.js`	1.42 kB	+31 B (2%)
`packages/base/lib/useViewportRange.js`	452 B	-8 B (1%)
`packages/main/lib/Form.js`	2.57 kB	-9 B (0%)
`packages/main/lib/ThemeProvider.js`	1.16 kB	+112 B (9%)	🔍
`packages/base/lib/Media.js`	3.68 kB	+3.68 kB (100%)	🆘

ℹ️ View Unchanged

Filename	Size	Change
`packages/base/lib/createComponentStyles.js`	206 B	0 B
`packages/base/lib/CssSizeVariables.js`	918 B	0 B
`packages/base/lib/Logger.js`	1.2 kB	0 B
`packages/base/lib/spacing.js`	997 B	0 B
`packages/base/lib/StyleClassHelper.js`	610 B	0 B
`packages/base/lib/ThemingParameters.js`	3.4 kB	0 B
`packages/base/lib/useConsolidatedRef.js`	271 B	0 B
`packages/base/lib/usePassThroughHtmlProps.js`	321 B	0 B
`packages/base/lib/Utils.js`	647 B	0 B
`packages/charts/lib/BarChart.js`	3.81 kB	0 B
`packages/charts/lib/BarChartPlaceholder.js`	456 B	0 B
`packages/charts/lib/ColumnChart.js`	4.04 kB	0 B
`packages/charts/lib/ColumnChartPlaceholder.js`	514 B	0 B
`packages/charts/lib/components/ChartContainer.js`	941 B	0 B
`packages/charts/lib/components/ChartDataLabel.js`	605 B	0 B
`packages/charts/lib/components/ComposedChartPlaceholder.js`	878 B	0 B
`packages/charts/lib/components/XAxisTicks.js`	596 B	0 B
`packages/charts/lib/components/YAxisTicks.js`	513 B	0 B
`packages/charts/lib/ComposedChart.js`	4.77 kB	0 B
`packages/charts/lib/DonutChart.js`	2.73 kB	0 B
`packages/charts/lib/LineChart.js`	3.92 kB	0 B
`packages/charts/lib/LineChartPlaceholder.js`	529 B	0 B
`packages/charts/lib/MicroBarChart.js`	1.87 kB	0 B
`packages/charts/lib/PieChart.js`	2.67 kB	0 B
`packages/charts/lib/PieChartPlaceholder.js`	445 B	0 B
`packages/charts/lib/RadarChart.js`	2.01 kB	0 B
`packages/charts/lib/RadialChart.js`	1.08 kB	0 B
`packages/charts/lib/ScatterChart.js`	3.56 kB	0 B
`packages/charts/lib/ScatterChartPlaceholder.js`	535 B	0 B
`packages/charts/lib/useLegendItemClick.js`	391 B	0 B
`packages/charts/lib/Utils.js`	534 B	0 B
`packages/main/lib/ActionSheet.js`	1.21 kB	0 B
`packages/main/lib/AnalyticalCard.js`	748 B	0 B
`packages/main/lib/AnalyticalCardHeader.js`	2.69 kB	0 B
`packages/main/lib/AnalyticalTable.js`	16.8 kB	0 B
`packages/main/lib/AnalyticalTableScrollMode.js`	177 B	0 B
`packages/main/lib/Avatar.js`	417 B	0 B
`packages/main/lib/AvatarBackgroundColor.js`	219 B	0 B
`packages/main/lib/AvatarFitType.js`	151 B	0 B
`packages/main/lib/AvatarShape.js`	150 B	0 B
`packages/main/lib/AvatarSize.js`	155 B	0 B
`packages/main/lib/Badge.js`	300 B	0 B
`packages/main/lib/Bar.js`	1.28 kB	0 B
`packages/main/lib/BarDesign.js`	177 B	0 B
`packages/main/lib/Breadcrumbs.js`	718 B	0 B
`packages/main/lib/BreadcrumbsSeparatorStyle.js`	198 B	0 B
`packages/main/lib/BusyIndicator.js`	337 B	0 B
`packages/main/lib/BusyIndicatorSize.js`	167 B	0 B
`packages/main/lib/Button.js`	351 B	0 B
`packages/main/lib/ButtonDesign.js`	190 B	0 B
`packages/main/lib/Calendar.js`	352 B	0 B
`packages/main/lib/CalendarType.js`	212 B	0 B
`packages/main/lib/Card.js`	327 B	0 B
`packages/main/lib/Carousel.js`	424 B	0 B
`packages/main/lib/CarouselArrowsPlacement.js`	166 B	0 B
`packages/main/lib/CheckBox.js`	370 B	0 B
`packages/main/lib/ComboBox.js`	408 B	0 B
`packages/main/lib/ComboBoxItem.js`	289 B	0 B
`packages/main/lib/ContentDensity.js`	151 B	0 B
`packages/main/lib/CustomListItem.js`	344 B	0 B
`packages/main/lib/DatePicker.js`	465 B	0 B
`packages/main/lib/DateRangePicker.js`	484 B	0 B
`packages/main/lib/DateTimePicker.js`	471 B	0 B
`packages/main/lib/DeviationIndicator.js`	160 B	0 B
`packages/main/lib/Dialog.js`	363 B	0 B
`packages/main/lib/DurationPicker.js`	433 B	0 B
`packages/main/lib/FCLLayout.js`	236 B	0 B
`packages/main/lib/FileUploader.js`	383 B	0 B
`packages/main/lib/FilterBar.js`	6.76 kB	0 B
`packages/main/lib/FilterGroupItem.js`	1.23 kB	0 B
`packages/main/lib/FilterItem.js`	1.62 kB	0 B
`packages/main/lib/FilterType.js`	170 B	0 B
`packages/main/lib/FlexBox.js`	967 B	0 B
`packages/main/lib/FlexBoxAlignItems.js`	189 B	0 B
`packages/main/lib/FlexBoxDirection.js`	169 B	0 B
`packages/main/lib/FlexBoxJustifyContent.js`	194 B	0 B
`packages/main/lib/FlexBoxWrap.js`	154 B	0 B
`packages/main/lib/FlexibleColumnLayout.js`	370 B	0 B
`packages/main/lib/FormGroup.js`	400 B	0 B
`packages/main/lib/FormItem.js`	1.05 kB	0 B
`packages/main/lib/GlobalStyleClasses.js`	151 B	0 B
`packages/main/lib/Grid.js`	1.58 kB	0 B
`packages/main/lib/GridPosition.js`	157 B	0 B
`packages/main/lib/GroupHeaderListItem.js`	313 B	0 B
`packages/main/lib/Icon.js`	323 B	0 B
`packages/main/lib/Input.js`	472 B	0 B
`packages/main/lib/InputType.js`	184 B	0 B
`packages/main/lib/Label.js`	322 B	0 B
`packages/main/lib/Link.js`	341 B	0 B
`packages/main/lib/LinkDesign.js`	191 B	0 B
`packages/main/lib/List.js`	432 B	0 B
`packages/main/lib/ListItemTypes.js`	160 B	0 B
`packages/main/lib/ListMode.js`	191 B	0 B
`packages/main/lib/ListSeparators.js`	186 B	0 B
`packages/main/lib/Loader.js`	1.3 kB	0 B
`packages/main/lib/LoaderType.js`	152 B	0 B
`packages/main/lib/MessageBox.js`	2.35 kB	0 B
`packages/main/lib/MessageBoxActions.js`	231 B	0 B
`packages/main/lib/MessageBoxTypes.js`	232 B	0 B
`packages/main/lib/MessageStrip.js`	351 B	0 B
`packages/main/lib/MessageStripType.js`	181 B	0 B
`packages/main/lib/MultiComboBox.js`	419 B	0 B
`packages/main/lib/MultiComboBoxItem.js`	309 B	0 B
`packages/main/lib/NotificationListGroupItem.js`	410 B	0 B
`packages/main/lib/NotificationListItem.js`	404 B	0 B
`packages/main/lib/NotificationOverflowAction.js`	310 B	0 B
`packages/main/lib/ObjectPage.js`	9.13 kB	0 B
`packages/main/lib/ObjectPageMode.js`	159 B	0 B
`packages/main/lib/ObjectPageSection.js`	1.25 kB	0 B
`packages/main/lib/ObjectPageSubSection.js`	1.08 kB	0 B
`packages/main/lib/ObjectStatus.js`	1.2 kB	0 B
`packages/main/lib/Option.js`	303 B	0 B
`packages/main/lib/Page.js`	2.03 kB	0 B
`packages/main/lib/PageBackgroundDesign.js`	183 B	0 B
`packages/main/lib/Panel.js`	379 B	0 B
`packages/main/lib/PanelAccessibleRoles.js`	201 B	0 B
`packages/main/lib/PlacementType.js`	175 B	0 B
`packages/main/lib/Popover.js`	485 B	0 B
`packages/main/lib/PopoverHorizontalAlign.js`	181 B	0 B
`packages/main/lib/PopoverPlacementType.js`	172 B	0 B
`packages/main/lib/PopoverVerticalAlign.js`	204 B	0 B
`packages/main/lib/Priority.js`	163 B	0 B
`packages/main/lib/ProductSwitch.js`	288 B	0 B
`packages/main/lib/ProductSwitchItem.js`	340 B	0 B
`packages/main/lib/ProgressIndicator.js`	359 B	0 B
`packages/main/lib/RadioButton.js`	378 B	0 B
`packages/main/lib/RatingIndicator.js`	345 B	0 B
`packages/main/lib/ResponsivePopover.js`	500 B	0 B
`packages/main/lib/SegmentedButton.js`	300 B	0 B
`packages/main/lib/Select.js`	333 B	0 B
`packages/main/lib/SemanticColor.js`	181 B	0 B
`packages/main/lib/ShellBar.js`	436 B	0 B
`packages/main/lib/ShellBarItem.js`	327 B	0 B
`packages/main/lib/SideNavigation.js`	328 B	0 B
`packages/main/lib/SideNavigationItem.js`	337 B	0 B
`packages/main/lib/SideNavigationSubItem.js`	329 B	0 B
`packages/main/lib/Size.js`	151 B	0 B
`packages/main/lib/Spinner.js`	1.2 kB	0 B
`packages/main/lib/StandardListItem.js`	407 B	0 B
`packages/main/lib/SuggestionItem.js`	397 B	0 B
`packages/main/lib/Switch.js`	330 B	0 B
`packages/main/lib/Tab.js`	362 B	0 B
`packages/main/lib/TabContainer.js`	393 B	0 B
`packages/main/lib/TabContainerTabsPlacement.js`	161 B	0 B
`packages/main/lib/TabLayout.js`	150 B	0 B
`packages/main/lib/Table.js`	346 B	0 B
`packages/main/lib/TableCell.js`	283 B	0 B
`packages/main/lib/TableColumn.js`	332 B	0 B
`packages/main/lib/TablePlaceholder.js`	771 B	0 B
`packages/main/lib/TableRow.js`	281 B	0 B
`packages/main/lib/TableScaleWidthMode.js`	169 B	0 B
`packages/main/lib/TableSelectionBehavior.js`	178 B	0 B
`packages/main/lib/TableSelectionMode.js`	182 B	0 B
`packages/main/lib/TabSeparator.js`	283 B	0 B
`packages/main/lib/Text.js`	798 B	0 B
`packages/main/lib/TextAlign.js`	183 B	0 B
`packages/main/lib/TextArea.js`	450 B	0 B
`packages/main/lib/Themes.js`	188 B	0 B
`packages/main/lib/Timeline.js`	277 B	0 B
`packages/main/lib/TimelineItem.js`	337 B	0 B
`packages/main/lib/TimePicker.js`	399 B	0 B
`packages/main/lib/Title.js`	317 B	0 B
`packages/main/lib/TitleLevel.js`	163 B	0 B
`packages/main/lib/Toast.js`	330 B	0 B
`packages/main/lib/ToastPlacement.js`	208 B	0 B
`packages/main/lib/ToggleButton.js`	371 B	0 B
`packages/main/lib/Token.js`	206 B	0 B
`packages/main/lib/Tokenizer.js`	223 B	0 B
`packages/main/lib/Toolbar.js`	3 kB	0 B
`packages/main/lib/ToolbarDesign.js`	175 B	0 B
`packages/main/lib/ToolbarSeparator.js`	477 B	0 B
`packages/main/lib/ToolbarSpacer.js`	220 B	0 B
`packages/main/lib/ToolbarStyle.js`	153 B	0 B
`packages/main/lib/Tree.js`	363 B	0 B
`packages/main/lib/TreeItem.js`	334 B	0 B
`packages/main/lib/UploadCollection.js`	378 B	0 B
`packages/main/lib/UploadCollectionItem.js`	436 B	0 B
`packages/main/lib/UploadState.js`	170 B	0 B
`packages/main/lib/ValueState.js`	182 B	0 B
`packages/main/lib/VariantManagement.js`	2.05 kB	0 B
`packages/main/lib/VerticalAlign.js`	174 B	0 B
`packages/main/lib/withWebComponent.js`	1.58 kB	0 B

_{compressed-size-action}

coveralls · 2020-10-01T07:23:51Z

Coverage increased (+0.6%) to 65.379% when pulling 2e10ae4 on refactor/device into cce75e2 on master.

…nents-react into refactor/device

…act into refactor/device

MarcusNotheis added 10 commits September 30, 2020 08:48

refactor(Device): replace modernizr with custom implementation

e163960

chore: refactor Device Support and Media to be standalone functions

2eac564

deprecated browser, os and system

0a16bea

deprecate support methods

c153046

remove internal usages of deprecated methods

ea44029

make sure default range sets are always initialized

e971545

decouple resize and orientation change events from device

04225c8

deprecate orientation and resize class methods

fa8b0ec

deprecate media class methods

6d8c3b5

disable log entry for now

5e9867d

MarcusNotheis requested review from Lukas742 and vbersch as code owners October 1, 2020 07:17

Merge branch 'master' into refactor/device

305b685

MarcusNotheis and others added 12 commits October 1, 2020 10:44

add test coverage for support file

3c2265e

Merge branch 'refactor/device' of https://github.com/SAP/ui5-webcompo…

ea3d4c0

…nents-react into refactor/device

add test for resize and orientation change

479773c

update media test

b358386

add test for changeRootCssClasses

499f079

fix wrong import in deprecation message

da8ba7a

add typings for UI5 Device

f8c80b2

add path resolution to storybook config

d8d14c4

Merge branch 'master' into refactor/device

bade78f

add path resolution to jest config

0ca44c9

Merge branch 'refactor/device' of github.com:SAP/ui5-webcomponents-re…

4b90075

…act into refactor/device

fix device lib export

75d955d

Lukas742 approved these changes Oct 5, 2020

View reviewed changes

MarcusNotheis added 2 commits October 5, 2020 12:28

Merge branch 'master' into refactor/device

f3b8679

add copyright for useIsomorphicLayoutEffect

4e005e6

download MIT license

2e10ae4

MarcusNotheis merged commit 64d6d6a into master Oct 5, 2020

MarcusNotheis deleted the refactor/device branch October 5, 2020 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(Device): deprecate Device class and move all methods to smaller util functions #697

refactor(Device): deprecate Device class and move all methods to smaller util functions #697

Uh oh!

MarcusNotheis commented Oct 1, 2020

Uh oh!

github-actions bot commented Oct 1, 2020 •

edited

Loading

Uh oh!

coveralls commented Oct 1, 2020 •

edited

Loading

Uh oh!

Uh oh!

refactor(Device): deprecate Device class and move all methods to smaller util functions #697

refactor(Device): deprecate Device class and move all methods to smaller util functions #697

Uh oh!

Conversation

MarcusNotheis commented Oct 1, 2020

Uh oh!

github-actions bot commented Oct 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2020 •

edited

Loading

coveralls commented Oct 1, 2020 •

edited

Loading