refactor: migrate popover stories to mdx #712

Lukas742 · 2020-10-06T16:55:48Z

Affected components:

Dialog
ResponsivePopover
Popover

… create a single component

github-actions · 2020-10-06T17:00:15Z

Size Change: 0 B

Total Size: 171 kB

ℹ️ View Unchanged

Filename	Size	Change
`packages/base/lib/createComponentStyles.js`	206 B	0 B
`packages/base/lib/CssSizeVariables.js`	918 B	0 B
`packages/base/lib/Device.js`	6.82 kB	0 B
`packages/base/lib/hooks.js`	1.42 kB	0 B
`packages/base/lib/Logger.js`	1.2 kB	0 B
`packages/base/lib/Media.js`	3.68 kB	0 B
`packages/base/lib/spacing.js`	997 B	0 B
`packages/base/lib/StyleClassHelper.js`	610 B	0 B
`packages/base/lib/ThemingParameters.js`	3.4 kB	0 B
`packages/base/lib/useConsolidatedRef.js`	271 B	0 B
`packages/base/lib/usePassThroughHtmlProps.js`	321 B	0 B
`packages/base/lib/useViewportRange.js`	452 B	0 B
`packages/base/lib/Utils.js`	647 B	0 B
`packages/charts/lib/BarChart.js`	3.81 kB	0 B
`packages/charts/lib/BarChartPlaceholder.js`	456 B	0 B
`packages/charts/lib/ColumnChart.js`	4.04 kB	0 B
`packages/charts/lib/ColumnChartPlaceholder.js`	514 B	0 B
`packages/charts/lib/components/ChartContainer.js`	941 B	0 B
`packages/charts/lib/components/ChartDataLabel.js`	605 B	0 B
`packages/charts/lib/components/ComposedChartPlaceholder.js`	878 B	0 B
`packages/charts/lib/components/XAxisTicks.js`	596 B	0 B
`packages/charts/lib/components/YAxisTicks.js`	513 B	0 B
`packages/charts/lib/ComposedChart.js`	4.77 kB	0 B
`packages/charts/lib/DonutChart.js`	2.73 kB	0 B
`packages/charts/lib/LineChart.js`	3.92 kB	0 B
`packages/charts/lib/LineChartPlaceholder.js`	529 B	0 B
`packages/charts/lib/MicroBarChart.js`	1.87 kB	0 B
`packages/charts/lib/PieChart.js`	2.67 kB	0 B
`packages/charts/lib/PieChartPlaceholder.js`	445 B	0 B
`packages/charts/lib/RadarChart.js`	2.01 kB	0 B
`packages/charts/lib/RadialChart.js`	1.08 kB	0 B
`packages/charts/lib/ScatterChart.js`	3.56 kB	0 B
`packages/charts/lib/ScatterChartPlaceholder.js`	535 B	0 B
`packages/charts/lib/useLegendItemClick.js`	391 B	0 B
`packages/charts/lib/Utils.js`	534 B	0 B
`packages/main/lib/ActionSheet.js`	1.21 kB	0 B
`packages/main/lib/AnalyticalCard.js`	748 B	0 B
`packages/main/lib/AnalyticalCardHeader.js`	2.69 kB	0 B
`packages/main/lib/AnalyticalTable.js`	16.8 kB	0 B
`packages/main/lib/AnalyticalTableScrollMode.js`	177 B	0 B
`packages/main/lib/Avatar.js`	563 B	0 B
`packages/main/lib/AvatarBackgroundColor.js`	219 B	0 B
`packages/main/lib/AvatarFitType.js`	151 B	0 B
`packages/main/lib/AvatarShape.js`	150 B	0 B
`packages/main/lib/AvatarSize.js`	155 B	0 B
`packages/main/lib/Badge.js`	451 B	0 B
`packages/main/lib/Bar.js`	1.28 kB	0 B
`packages/main/lib/BarDesign.js`	177 B	0 B
`packages/main/lib/Breadcrumbs.js`	718 B	0 B
`packages/main/lib/BreadcrumbsSeparatorStyle.js`	198 B	0 B
`packages/main/lib/BusyIndicator.js`	450 B	0 B
`packages/main/lib/BusyIndicatorSize.js`	167 B	0 B
`packages/main/lib/Button.js`	459 B	0 B
`packages/main/lib/ButtonDesign.js`	190 B	0 B
`packages/main/lib/Calendar.js`	444 B	0 B
`packages/main/lib/CalendarType.js`	212 B	0 B
`packages/main/lib/Card.js`	496 B	0 B
`packages/main/lib/Carousel.js`	538 B	0 B
`packages/main/lib/CarouselArrowsPlacement.js`	166 B	0 B
`packages/main/lib/CheckBox.js`	604 B	0 B
`packages/main/lib/ComboBox.js`	539 B	0 B
`packages/main/lib/ComboBoxItem.js`	323 B	0 B
`packages/main/lib/ContentDensity.js`	151 B	0 B
`packages/main/lib/CustomListItem.js`	454 B	0 B
`packages/main/lib/DatePicker.js`	610 B	0 B
`packages/main/lib/DateRangePicker.js`	563 B	0 B
`packages/main/lib/DateTimePicker.js`	582 B	0 B
`packages/main/lib/DeviationIndicator.js`	160 B	0 B
`packages/main/lib/Dialog.js`	713 B	0 B
`packages/main/lib/DurationPicker.js`	553 B	0 B
`packages/main/lib/FCLLayout.js`	236 B	0 B
`packages/main/lib/FileUploader.js`	689 B	0 B
`packages/main/lib/FilterBar.js`	6.76 kB	0 B
`packages/main/lib/FilterGroupItem.js`	1.23 kB	0 B
`packages/main/lib/FilterItem.js`	1.62 kB	0 B
`packages/main/lib/FilterType.js`	170 B	0 B
`packages/main/lib/FlexBox.js`	967 B	0 B
`packages/main/lib/FlexBoxAlignItems.js`	189 B	0 B
`packages/main/lib/FlexBoxDirection.js`	169 B	0 B
`packages/main/lib/FlexBoxJustifyContent.js`	194 B	0 B
`packages/main/lib/FlexBoxWrap.js`	154 B	0 B
`packages/main/lib/FlexibleColumnLayout.js`	511 B	0 B
`packages/main/lib/Form.js`	2.57 kB	0 B
`packages/main/lib/FormGroup.js`	400 B	0 B
`packages/main/lib/FormItem.js`	1.05 kB	0 B
`packages/main/lib/GlobalStyleClasses.js`	151 B	0 B
`packages/main/lib/Grid.js`	1.58 kB	0 B
`packages/main/lib/GridPosition.js`	157 B	0 B
`packages/main/lib/GroupHeaderListItem.js`	375 B	0 B
`packages/main/lib/Icon.js`	516 B	0 B
`packages/main/lib/Input.js`	864 B	0 B
`packages/main/lib/InputType.js`	184 B	0 B
`packages/main/lib/Label.js`	587 B	0 B
`packages/main/lib/Link.js`	524 B	0 B
`packages/main/lib/LinkDesign.js`	191 B	0 B
`packages/main/lib/List.js`	757 B	0 B
`packages/main/lib/ListItemTypes.js`	160 B	0 B
`packages/main/lib/ListMode.js`	191 B	0 B
`packages/main/lib/ListSeparators.js`	186 B	0 B
`packages/main/lib/Loader.js`	1.3 kB	0 B
`packages/main/lib/LoaderType.js`	152 B	0 B
`packages/main/lib/MessageBox.js`	2.35 kB	0 B
`packages/main/lib/MessageBoxActions.js`	231 B	0 B
`packages/main/lib/MessageBoxTypes.js`	232 B	0 B
`packages/main/lib/MessageStrip.js`	514 B	0 B
`packages/main/lib/MessageStripType.js`	181 B	0 B
`packages/main/lib/MultiComboBox.js`	694 B	0 B
`packages/main/lib/MultiComboBoxItem.js`	347 B	0 B
`packages/main/lib/NotificationListGroupItem.js`	621 B	0 B
`packages/main/lib/NotificationListItem.js`	405 B	0 B
`packages/main/lib/NotificationOverflowAction.js`	434 B	0 B
`packages/main/lib/ObjectPage.js`	9.25 kB	0 B
`packages/main/lib/ObjectPageMode.js`	159 B	0 B
`packages/main/lib/ObjectPageSection.js`	1.25 kB	0 B
`packages/main/lib/ObjectPageSubSection.js`	1.08 kB	0 B
`packages/main/lib/ObjectStatus.js`	1.2 kB	0 B
`packages/main/lib/Option.js`	351 B	0 B
`packages/main/lib/Page.js`	2.03 kB	0 B
`packages/main/lib/PageBackgroundDesign.js`	183 B	0 B
`packages/main/lib/Panel.js`	479 B	0 B
`packages/main/lib/PanelAccessibleRoles.js`	201 B	0 B
`packages/main/lib/PlacementType.js`	175 B	0 B
`packages/main/lib/Popover.js`	629 B	0 B
`packages/main/lib/PopoverHorizontalAlign.js`	181 B	0 B
`packages/main/lib/PopoverPlacementType.js`	172 B	0 B
`packages/main/lib/PopoverVerticalAlign.js`	204 B	0 B
`packages/main/lib/Priority.js`	163 B	0 B
`packages/main/lib/ProductSwitch.js`	388 B	0 B
`packages/main/lib/ProductSwitchItem.js`	439 B	0 B
`packages/main/lib/ProgressIndicator.js`	435 B	0 B
`packages/main/lib/RadioButton.js`	606 B	0 B
`packages/main/lib/RatingIndicator.js`	434 B	0 B
`packages/main/lib/ResponsivePopover.js`	595 B	0 B
`packages/main/lib/SegmentedButton.js`	486 B	0 B
`packages/main/lib/Select.js`	420 B	0 B
`packages/main/lib/SemanticColor.js`	181 B	0 B
`packages/main/lib/ShellBar.js`	551 B	0 B
`packages/main/lib/ShellBarItem.js`	388 B	0 B
`packages/main/lib/SideNavigation.js`	568 B	0 B
`packages/main/lib/SideNavigationItem.js`	402 B	0 B
`packages/main/lib/SideNavigationSubItem.js`	373 B	0 B
`packages/main/lib/Size.js`	151 B	0 B
`packages/main/lib/Spinner.js`	1.2 kB	0 B
`packages/main/lib/StandardListItem.js`	514 B	0 B
`packages/main/lib/SuggestionItem.js`	439 B	0 B
`packages/main/lib/Switch.js`	610 B	0 B
`packages/main/lib/Tab.js`	479 B	0 B
`packages/main/lib/TabContainer.js`	520 B	0 B
`packages/main/lib/TabContainerTabsPlacement.js`	161 B	0 B
`packages/main/lib/TabLayout.js`	150 B	0 B
`packages/main/lib/Table.js`	620 B	0 B
`packages/main/lib/TableCell.js`	332 B	0 B
`packages/main/lib/TableColumn.js`	404 B	0 B
`packages/main/lib/TablePlaceholder.js`	771 B	0 B
`packages/main/lib/TableRow.js`	316 B	0 B
`packages/main/lib/TableScaleWidthMode.js`	169 B	0 B
`packages/main/lib/TableSelectionBehavior.js`	178 B	0 B
`packages/main/lib/TableSelectionMode.js`	182 B	0 B
`packages/main/lib/TabSeparator.js`	340 B	0 B
`packages/main/lib/Text.js`	798 B	0 B
`packages/main/lib/TextAlign.js`	183 B	0 B
`packages/main/lib/TextArea.js`	653 B	0 B
`packages/main/lib/ThemeProvider.js`	1.16 kB	0 B
`packages/main/lib/Themes.js`	188 B	0 B
`packages/main/lib/Timeline.js`	569 B	0 B
`packages/main/lib/TimelineItem.js`	356 B	0 B
`packages/main/lib/TimePicker.js`	544 B	0 B
`packages/main/lib/Title.js`	401 B	0 B
`packages/main/lib/TitleLevel.js`	163 B	0 B
`packages/main/lib/Toast.js`	420 B	0 B
`packages/main/lib/ToastPlacement.js`	208 B	0 B
`packages/main/lib/ToggleButton.js`	651 B	0 B
`packages/main/lib/Token.js`	206 B	0 B
`packages/main/lib/Tokenizer.js`	223 B	0 B
`packages/main/lib/Toolbar.js`	3 kB	0 B
`packages/main/lib/ToolbarDesign.js`	175 B	0 B
`packages/main/lib/ToolbarSeparator.js`	477 B	0 B
`packages/main/lib/ToolbarSpacer.js`	220 B	0 B
`packages/main/lib/ToolbarStyle.js`	153 B	0 B
`packages/main/lib/Tree.js`	417 B	0 B
`packages/main/lib/TreeItem.js`	418 B	0 B
`packages/main/lib/UploadCollection.js`	470 B	0 B
`packages/main/lib/UploadCollectionItem.js`	466 B	0 B
`packages/main/lib/UploadState.js`	170 B	0 B
`packages/main/lib/ValueState.js`	182 B	0 B
`packages/main/lib/VariantManagement.js`	2.05 kB	0 B
`packages/main/lib/VerticalAlign.js`	174 B	0 B
`packages/main/lib/withWebComponent.js`	1.58 kB	0 B

_{compressed-size-action}

coveralls · 2020-10-06T17:02:35Z

Coverage remained the same at 65.379% when pulling 39e8194 on reafactor/webcomponents-popovers-mdx into dd54dff on master.

MarcusNotheis

The descriptions are very good, but I'm missing some content within the popovers to be honest.

Dialog:

Please add a default headerText
Move the close button into the footer?
Maybe we can get rid of the with Content story and merge everything into the main story?

Popover:

Default story has no content, maybe merging the withContent story into it?

ResponsivePopover:

Default story has no content, maybe merging the withContent story into it?

…/ui5-webcomponents-react into reafactor/webcomponents-popovers-mdx

Lukas742 added 19 commits October 6, 2020 10:13

refactor Avatar story to mdx

92642e1

remove Avatar tsx story

4f3a68a

Add the possibility to the webcomponents-react wrapper script to only…

c04396d

… create a single component

refactor Badge story

7a2c109

refactor Button story

2ff53ca

webcomponents-react script supports icon import of Icon

22075cd

refactor Icon

9afca35

refactor Input main description + story

7187725

refactor Label story

371d621

refactor Link story

cad353a

refactor RatingIndicator prop description + story

666dfec

refactor Switch main description + story

b98892b

refactor Title story

1fbf61b

refactor ToggleButton prop description + story

7355a95

refactor TextArea story

8b1468c

add missing declaration to webcomponents-react wrapper script

e7a886c

refactor Popover story

be6de10

refactor ResponsivePopover Story

5eca706

refactor Dialog story

c911329

Lukas742 requested review from MarcusNotheis and vbersch as code owners October 6, 2020 16:55

Merge branch 'master' into reafactor/webcomponents-popovers-mdx

01458bf

MarcusNotheis requested changes Oct 7, 2020

View reviewed changes

Lukas742 added 2 commits October 7, 2020 10:11

revise popover stories, add story to Popover component

f524ff3

Merge branch 'reafactor/webcomponents-popovers-mdx' of github.com:SAP…

4f2022c

…/ui5-webcomponents-react into reafactor/webcomponents-popovers-mdx

Lukas742 requested a review from MarcusNotheis October 7, 2020 08:18

Merge branch 'master' into reafactor/webcomponents-popovers-mdx

39e8194

MarcusNotheis approved these changes Oct 7, 2020

View reviewed changes

MarcusNotheis merged commit bc6e13f into master Oct 7, 2020

MarcusNotheis deleted the reafactor/webcomponents-popovers-mdx branch October 7, 2020 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: migrate popover stories to mdx #712

refactor: migrate popover stories to mdx #712

Uh oh!

Lukas742 commented Oct 6, 2020 •

edited

Loading

Uh oh!

github-actions bot commented Oct 6, 2020 •

edited

Loading

Uh oh!

coveralls commented Oct 6, 2020 •

edited

Loading

Uh oh!

MarcusNotheis left a comment •

edited by Lukas742

Loading

Uh oh!

Uh oh!

refactor: migrate popover stories to mdx #712

refactor: migrate popover stories to mdx #712

Uh oh!

Conversation

Lukas742 commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarcusNotheis left a comment • edited by Lukas742 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lukas742 commented Oct 6, 2020 •

edited

Loading

github-actions bot commented Oct 6, 2020 •

edited

Loading

coveralls commented Oct 6, 2020 •

edited

Loading

MarcusNotheis left a comment •

edited by Lukas742

Loading