Skip to content

Commit c850ff1

Browse files
PetyaMarkovaBogdanovaPetyaMarkovaBogdanova
andauthored
fix(ui5-dynamic-page): action buttons reading fix (#9858)
Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
1 parent 1fb85c6 commit c850ff1

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/fiori/src/DynamicPageHeaderActions.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
icon="{{arrowButtonIcon}}"
77
accessible-name="{{expandLabel}}"
88
.accessibilityAttributes="{{accessibilityAttributes}}"
9-
title="{{expandLabel}}"
9+
tooltip="{{expandLabel}}"
1010
@mouseover="{{onExpandHoverIn}}"
1111
@mouseout="{{onExpandHoverOut}}"
1212
></ui5-button>
@@ -18,7 +18,7 @@
1818
?pressed="{{pinned}}"
1919
.accessibilityAttributes="{{accessibilityAttributes}}"
2020
accessible-name="{{pinLabel}}"
21-
title="{{pinLabel}}"
21+
tooltip="{{pinLabel}}"
2222
></ui5-toggle-button>
2323
{{/if}}
2424
</div>

packages/fiori/test/specs/DynamicPage.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -408,12 +408,12 @@ describe("ARIA attributes", () => {
408408

409409
assert.strictEqual(await expandButton.getProperty("accessibleName"), "Snap Header",
410410
"expand button accessible-name is correct");
411-
assert.strictEqual(await expandButton.getProperty("title"), "Snap Header",
411+
assert.strictEqual(await expandButton.getProperty("tooltip"), "Snap Header",
412412
"expand button accessible-name is correct");
413413

414414
assert.strictEqual(await pinButton.getProperty("accessibleName"), "Pin Header",
415415
"pin button accessible-name is correct");
416-
assert.strictEqual(await pinButton.getProperty("title"), "Pin Header",
416+
assert.strictEqual(await pinButton.getProperty("tooltip"), "Pin Header",
417417
"pin button accessible-name is correct");
418418
});
419419

@@ -447,7 +447,7 @@ describe("ARIA attributes", () => {
447447
assert.ok(await expandButton.isExisting(), "expand button is rendered");
448448
assert.strictEqual(await expandButton.getProperty("accessibleName"), "Expand Header",
449449
"expand button accessible-name is correct");
450-
assert.strictEqual(await expandButton.getProperty("title"), "Expand Header",
450+
assert.strictEqual(await expandButton.getProperty("tooltip"), "Expand Header",
451451
"expand button tooltip is correct");
452452
});
453453
});

0 commit comments

Comments
 (0)