Skip to content

Commit 59b9099

Browse files
Merge pull request #465 from SciML/qr
Fix and test QR
2 parents 5912dd7 + 4980386 commit 59b9099

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

src/function_registration.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ Base.:^(x::Expression,y::T) where T <: Rational = Operation(Base.:^, Expression[
109109
@register Base.conj(x)
110110
@register Base.getindex(x,i)
111111
@register Base.binomial(n,k)
112+
@register Base.copysign(x,y)
112113

113114
Base.getindex(x::Operation,i::Int64) = Operation(getindex,[x,i])
114115
Base.one(::Operation) = 1

src/operations.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,3 +79,4 @@ Base.promote_rule(::Type{<:Constant}, ::Type{<:Operation}) = Operation
7979
Base.promote_rule(::Type{<:Operation}, ::Type{<:Constant}) = Operation
8080

8181
LinearAlgebra.lu(O::AbstractMatrix{<:Operation};kwargs...) = lu(O,Val(false);kwargs...)
82+
Base.real(x::Operation) = x

test/operation_overloads.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ X = [a b;c d]
1010
det(X)
1111
lu(X)
1212
inv(X)
13+
qr(X)
1314

1415
# test operations with sparse arrays and Operations
1516
# note `isequal` instead of `==` because `==` would give another Operation

0 commit comments

Comments
 (0)