Merge pull request #2807 from AayushSabharwal/as/mtkparams-undef-validation

fix: error properly on missing parameter values

Author: ChrisRackauckas

src/systems/parameter_buffer.jl

@@ -139,7 +139,7 @@ function MTKParameters(
         val = unwrap(val)
         ctype = symtype(sym)
         if symbolic_type(val) !== NotSymbolic()
-            continue
+            error("Could not evaluate value of parameter $sym. Missing values for variables in expression $val.")
         end
         val = symconvert(ctype, val)
         done = set_value(sym, val)

test/mtkparameters.jl

@@ -283,3 +283,10 @@ VVDual = Vector{<:Vector{<:ForwardDiff.Dual}}
     @test_throws TypeError remake_buffer(sys, ps, Dict(e => Foo(2.0))) # need exact same type for nonnumeric
     @test_nowarn remake_buffer(sys, ps, Dict(f => Foo(:a)))
 end
+
+@testset "Error on missing parameter defaults" begin
+    @parameters a b c
+    @named sys = ODESystem(Equation[], t, [], [a, b]; defaults = Dict(b => 2c))
+    sys = complete(sys)
+    @test_throws ["Could not evaluate", "b", "Missing", "2c"] MTKParameters(sys, [a => 1.0])
+end