Merge branch 'master' into myb/state_machine

Author: YingboMa

NEWS.md

@@ -33,7 +33,10 @@
     `@parameters p::Int`. Array-valued parameters must be array symbolics; `@parameters p = [1.0, 2.0]`
     is now invalid and must be changed to `@parameters p[1:2] = [1.0, 2.0]`. The index of a parameter
     in the system is also not guaranteed to be an `Int`, and will instead be a custom undocumented type.
-    To restore the old behavior:
+    Parameters that have a default value depending on other parameters are now treated as dependent
+    parameters. Their value cannot be modified directly. Whenever a parameter value is changed, dependent
+    parameter values are recalculated. For example, if `@parameters p1 p2 = 3p1` then `p2` can not be
+    modified directly. If `p1` is changed, then `p2` will be updated accordingly. To restore the old behavior:
 
       + Pass the `split = false` keyword to `structural_simplify`. E.g. `ss = structural_simplify(sys; split = false)`.
       + Pass `split = false` to `@mtkbuild`. E.g. `@mtkbuild sys = ODESystem(...) split = false`.

src/bipartite_graph.jl

@@ -88,7 +88,7 @@ function Base.push!(m::Matching, v)
     end
 end
 
-function complete(m::Matching{U}, N = length(m.match)) where {U}
+function complete(m::Matching{U}, N = maximum((x for x in m.match if isa(x, Int)); init=0)) where {U}
     m.inv_match !== nothing && return m
     inv_match = Union{U, Int}[unassigned for _ in 1:N]
     for (i, eq) in enumerate(m.match)

src/structural_transformation/partial_state_selection.jl

@@ -51,7 +51,7 @@ function pss_graph_modia!(structure::SystemStructure, maximal_top_matching, varl
         old_level_vars = ()
         ict = IncrementalCycleTracker(
             DiCMOBiGraph{true}(graph,
-                complete(Matching(ndsts(graph))));
+			       complete(Matching(ndsts(graph)), nsrcs(graph))),
             dir = :in)
 
         while level >= 0
@@ -124,7 +124,7 @@ function pss_graph_modia!(structure::SystemStructure, maximal_top_matching, varl
             level -= 1
         end
     end
-    return complete(var_eq_matching)
+    return complete(var_eq_matching, nsrcs(graph))
 end
 
 struct SelectedUnknown end