-
-
Notifications
You must be signed in to change notification settings - Fork 224
update get_variables! for Equations #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks great. Is there anything else needed to get the dependency graph? Or can I now plot the direct connections say between variables today? |
You can get a LightGraph directed graph as: |
Is there an issue with NonlinearSystem? |
As long as |
Something like |
It's all in |
@ChrisRackauckas Assuming tests pass this should be good now. |
Oh, I might have misunderstood your earlier comment. This will do graphs showing which states an equation depends on currently, and all of eq-eq, eq-state, state-eq, state-state for jumps. State to state for ODEs needs a version of |
Added a version that can make all four dg types for ODEs/SDEs, correctly if the LHS of equations only involve one variable, which can be assumed to be the one modified by the equation. |
Notes;
get_variables!
returnsOperations
, but we also havevars
which returnsVariables
, so we have some redundancy here.I still need tests for ODEs here, but local testing looks ok.