revert back to using a parameter eval module #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| parammap = map((x,y)->Pair(x(),y),parameters(js),pars) | ||
| parammap = Dict(convert(Variable,param) => pars[i] for (i,param) in enumerate(parameters(js))) | ||
| pvars = parameters(js) | ||
| param_context = Module() |
There was a problem hiding this comment.
the downside is that I think these models won't precompile.
There was a problem hiding this comment.
We should definitely look for another solution long term, but this gives us a short-term fix at least...
ChrisRackauckas
approved these changes
Jun 4, 2020
|
Not sure why tests didn't run. I'll close and re-open. Assuming they pass this should be good to merge. |
|
Hmm, for some reason it seem the Travis tests aren't being queued... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is room to do better still, for example, I think we can get another ~20% speed up by having the
ReactionSystemcalculate the combinatoric stoichiometry factor for the rescaled rate. I'll work on that tomorrow or Friday if I have some time. Still, this gives a noticeable improvement.