Skip to content

Commit 8cad123

Browse files
committed
refactor: fix type piracy
1 parent d8ece0d commit 8cad123

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

src/UDEComponents.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ using ComponentArrays: ComponentArray
1111
export create_ude_component, multi_layer_feed_forward
1212

1313
include("utils.jl")
14-
include("hacks.jl") # this should be removed / upstreamed
1514

1615
"""
1716
create_ude_component(n_input = 1, n_output = 1;
@@ -42,4 +41,8 @@ function create_ude_component(n_input = 1,
4241
return ude_comp
4342
end
4443

44+
function lazyconvert(T, x::Symbolics.Arr)
45+
Symbolics.array_term(convert, T, x, size = size(x))
46+
end
47+
4548
end

src/hacks.jl

Lines changed: 0 additions & 4 deletions
This file was deleted.

test/qa.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ using JET
77
Aqua.find_persistent_tasks_deps(UDEComponents)
88
Aqua.test_ambiguities(UDEComponents, recursive = false)
99
Aqua.test_deps_compat(UDEComponents)
10-
# TODO: fix type piracy in propagate_ndims and propagate_shape
11-
Aqua.test_piracies(UDEComponents, broken = true)
10+
Aqua.test_piracies(UDEComponents)
1211
Aqua.test_project_extras(UDEComponents)
1312
Aqua.test_stale_deps(UDEComponents, ignore = Symbol[])
1413
Aqua.test_unbound_args(UDEComponents)

0 commit comments

Comments
 (0)