Skip to content

Commit 069e7c5

Browse files
author
Brad Carman
committed
format fix
1 parent 133176a commit 069e7c5

File tree

3 files changed

+35
-48
lines changed

3 files changed

+35
-48
lines changed

src/Hydraulic/IsothermalCompressible/IsothermalCompressible.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,4 @@ include("utils.jl")
1616
export Source, InputSource, FixedVolume, Pipe
1717
include("components.jl")
1818

19-
20-
end
19+
end

src/Hydraulic/IsothermalCompressible/components.jl

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,24 +63,18 @@ Caps a hydrualic port to prevent mass flow in or out.
6363
- `port`: hydraulic port
6464
"""
6565
@component function Cap(; p_int, name)
66-
pars = @parameters p_int = p_int
66+
pars = @parameters p_int = p_int
6767

6868
vars = @variables p(t) = p_int
6969

7070
systems = @named begin port = HydraulicPort(; p_int = p_int) end
7171

72-
eqs = [
73-
port.p ~ p
74-
port.dm ~ 0
75-
]
72+
eqs = [port.p ~ p
73+
port.dm ~ 0]
7674

7775
ODESystem(eqs, t, vars, pars; name, systems)
7876
end
7977

80-
81-
82-
83-
8478
"""
8579
FixedVolume(; vol, p_int, name)
8680

test/Hydraulic/isothermal_compressible.jl

Lines changed: 31 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,12 @@ import ModelingToolkitStandardLibrary.Mechanical.Translational as T
77
D = Differential(t)
88

99
function system(N; bulk_modulus, name)
10-
pars = @parameters begin
11-
bulk_modulus = bulk_modulus
12-
end
10+
pars = @parameters begin bulk_modulus = bulk_modulus end
1311

1412
systems = @named begin
15-
fluid = IC.HydraulicFluid(;bulk_modulus)
16-
stp = B.Step(; height = 10e5, offset = 0, start_time = 0.005, duration = Inf, smooth = true)
13+
fluid = IC.HydraulicFluid(; bulk_modulus)
14+
stp = B.Step(; height = 10e5, offset = 0, start_time = 0.005, duration = Inf,
15+
smooth = true)
1716
src = IC.InputSource(; p_int = 0)
1817
vol = IC.FixedVolume(; p_int = 0, vol = 10.0)
1918
end
@@ -25,23 +24,24 @@ function system(N; bulk_modulus, name)
2524
end
2625
push!(systems, res)
2726

28-
eqs = [ connect(stp.output, src.input)
29-
connect(fluid, src.port)
30-
connect(src.port, res.port_a)
31-
connect(res.port_b, vol.port)]
27+
eqs = [connect(stp.output, src.input)
28+
connect(fluid, src.port)
29+
connect(src.port, res.port_a)
30+
connect(res.port_b, vol.port)]
3231

3332
ODESystem(eqs, t, [], pars; name, systems)
3433
end
3534

36-
@named sys1_2 = system(1; bulk_modulus=2e9)
37-
@named sys1_1 = system(1; bulk_modulus=1e9)
38-
@named sys5_1 = system(5; bulk_modulus=1e9)
35+
@named sys1_2 = system(1; bulk_modulus = 2e9)
36+
@named sys1_1 = system(1; bulk_modulus = 1e9)
37+
@named sys5_1 = system(5; bulk_modulus = 1e9)
3938

4039
NEWTON = NLNewton(check_div = false, always_new = true, max_iter = 100, relax = 4 // 10)
4140

4241
syss = structural_simplify.([sys1_2, sys1_1, sys5_1])
4342
probs = [ODEProblem(sys, [], (0, 0.2)) for sys in syss];
44-
sols = [solve(prob, ImplicitEuler(nlsolve=NEWTON); initializealg=NoInit()) for prob in probs];
43+
sols = [solve(prob, ImplicitEuler(nlsolve = NEWTON); initializealg = NoInit())
44+
for prob in probs];
4545

4646
s1_2 = complete(sys1_2)
4747
s1_1 = complete(sys1_1)
@@ -64,50 +64,46 @@ s5_1 = complete(sys5_1)
6464
# Legend(fig[1,2], ax)
6565
# fig
6666

67-
68-
69-
7067
function system(; bulk_modulus, name)
71-
pars = @parameters begin
72-
bulk_modulus = bulk_modulus
73-
end
68+
pars = @parameters begin bulk_modulus = bulk_modulus end
7469

7570
systems = @named begin
76-
fluid = IC.HydraulicFluid(;bulk_modulus)
77-
stp = B.Step(; height = 10e5, offset = 0, start_time = 0.05, duration = Inf, smooth = 0.001)
71+
fluid = IC.HydraulicFluid(; bulk_modulus)
72+
stp = B.Step(; height = 10e5, offset = 0, start_time = 0.05, duration = Inf,
73+
smooth = 0.001)
7874
src = IC.InputSource(; p_int = 0)
79-
vol1 = IC.DynamicVolume(; p_int = 0, area=0.01, direction=+1)
80-
vol2 = IC.DynamicVolume(; p_int = 0, area=0.01, direction=-1, x_int=1.0)
81-
mass = T.Mass(; m=1000, s_0=0)
75+
vol1 = IC.DynamicVolume(; p_int = 0, area = 0.01, direction = +1)
76+
vol2 = IC.DynamicVolume(; p_int = 0, area = 0.01, direction = -1, x_int = 1.0)
77+
mass = T.Mass(; m = 1000, s_0 = 0)
8278
res = IC.PipeBase(; p_int = 0, area = 0.001, length = 50.0)
83-
cap = IC.Cap(;p_int=0)
79+
cap = IC.Cap(; p_int = 0)
8480
end
8581

86-
eqs = [ connect(stp.output, src.input)
87-
connect(fluid, src.port, cap.port)
88-
connect(src.port, res.port_a)
89-
connect(res.port_b, vol1.port)
90-
connect(vol1.flange, mass.flange, vol2.flange)
91-
connect(vol2.port, cap.port)]
82+
eqs = [connect(stp.output, src.input)
83+
connect(fluid, src.port, cap.port)
84+
connect(src.port, res.port_a)
85+
connect(res.port_b, vol1.port)
86+
connect(vol1.flange, mass.flange, vol2.flange)
87+
connect(vol2.port, cap.port)]
9288

9389
ODESystem(eqs, t, [], pars; name, systems)
9490
end
9591

96-
@named sys1 = system(; bulk_modulus=1e9)
97-
@named sys2 = system(; bulk_modulus=2e9)
92+
@named sys1 = system(; bulk_modulus = 1e9)
93+
@named sys2 = system(; bulk_modulus = 2e9)
9894

9995
syss = structural_simplify.([sys1, sys2])
10096
probs = [ODEProblem(sys, [], (0, 0.2)) for sys in syss];
10197
dt = 1e-4
102-
sols = [solve(prob, ImplicitEuler(nlsolve=NEWTON); adaptive=false, dt, initializealg=NoInit()) for prob in probs];
98+
sols = [solve(prob, ImplicitEuler(nlsolve = NEWTON); adaptive = false, dt,
99+
initializealg = NoInit()) for prob in probs];
103100

104101
s1 = complete(sys1)
105102
s2 = complete(sys2)
106103

107104
# less stiff will compress more
108105
@test maximum(sols[1][s1.mass.s]) > maximum(sols[2][s2.mass.s])
109106

110-
111107
# fig = Figure()
112108
# ax = Axis(fig[1,1])
113109
# lines!(ax, sols[1].t, sols[1][s1.src.port.p]; label="sorce", color=:black)
@@ -117,15 +113,13 @@ s2 = complete(sys2)
117113
# Legend(fig[1,2], ax)
118114
# fig
119115

120-
121116
# fig = Figure()
122117
# ax = Axis(fig[1,1])
123118
# scatterlines!(ax, sols[1].t, sols[1][s1.mass.s]; label="bulk=1e9")
124119
# scatterlines!(ax, sols[2].t, sols[2][s2.mass.s]; label="bulk=2e9")
125120
# Legend(fig[1,2], ax)
126121
# fig
127122

128-
129123
# fig = Figure()
130124
# ax = Axis(fig[1,1])
131125
# lines!(ax, sols[1].t, sols[1][s1.vol1.dx]; label="bulk=2e9")

0 commit comments

Comments
 (0)