Skip to content

Commit 7c13806

Browse files
refactor: use common definition of t and D from ModelingToolkit
1 parent 1fbd1d0 commit 7c13806

File tree

32 files changed

+31
-87
lines changed

32 files changed

+31
-87
lines changed

docs/src/connectors/connections.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,9 @@ As can be seen, this will give a 1 equation model matching our energy dissipatio
9090

9191
```@example connections
9292
using ModelingToolkitStandardLibrary.Electrical, ModelingToolkit, DifferentialEquations
93+
using ModelingToolkit: t_nounits as t
9394
using Plots
9495
95-
@parameters t
96-
9796
@named resistor = Resistor(R = 1)
9897
@named capacitor = Capacitor(C = 1)
9998
@named ground = Ground()

docs/src/tutorials/custom_component.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ First, we need to make some imports.
88

99
```@example components
1010
using ModelingToolkit
11+
using ModelingToolkit: t_nounits as t
1112
using ModelingToolkitStandardLibrary.Electrical
1213
using ModelingToolkitStandardLibrary.Electrical: OnePort
1314
using OrdinaryDiffEq
@@ -35,8 +36,6 @@ end NonlinearResistor;
3536
this can almost be directly translated to the syntax of `ModelingToolkit`.
3637

3738
```@example components
38-
@parameters t
39-
4039
function NonlinearResistor(; name, Ga, Gb, Ve)
4140
@named oneport = OnePort()
4241
@unpack v, i = oneport

docs/src/tutorials/dc_motor_pi.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,13 @@ First, the needed packages are imported and the parameters of the model defined.
1414

1515
```@example dc_motor_pi
1616
using ModelingToolkit
17+
using ModelingToolkit: t_nounits as t
1718
using ModelingToolkitStandardLibrary.Electrical
1819
using ModelingToolkitStandardLibrary.Mechanical.Rotational
1920
using ModelingToolkitStandardLibrary.Blocks
2021
using OrdinaryDiffEq
2122
using Plots
2223
23-
@parameters t
24-
2524
R = 0.5 # [Ohm] armature resistance
2625
L = 4.5e-3 # [H] armature inductance
2726
k = 0.5 # [N.m/A] motor constant

docs/src/tutorials/input_component.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,11 @@ The `ModelingToolkitStandardLibrary.Blocks.TimeVaryingFunction` component is eas
1414

1515
```julia
1616
using ModelingToolkit
17+
using ModelingToolkit: t_nounits as t, D_nounits as D
1718
using ModelingToolkitStandardLibrary.Blocks
1819
using DataInterpolations
1920
using OrdinaryDiffEq
2021

21-
@parameters t
22-
D = Differential(t)
23-
2422
function System(f; name)
2523
src = TimeVaryingFunction(f)
2624

docs/src/tutorials/thermal_model.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ from dividing the total initial energy in the system by the sum of the heat capa
88

99
```@example
1010
using ModelingToolkitStandardLibrary.Thermal, ModelingToolkit, OrdinaryDiffEq, Plots
11-
12-
@parameters t
11+
using ModelingToolkit: t_nounits as t
1312
1413
C1 = 15
1514
C2 = 15

src/Blocks/Blocks.jl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@ module Blocks
55
using ModelingToolkit, Symbolics
66
import IfElse: ifelse
77
import ..@symcheck
8-
using ModelingToolkit: getdefault
9-
10-
@parameters t
11-
D = Differential(t)
8+
using ModelingToolkit: getdefault, t_nounits as t, D_nounits as D
129

1310
export RealInput, RealOutput, SISO
1411
include("utils.jl")

src/Electrical/Electrical.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@ This library contains electrical components to build up analog circuits.
55
module Electrical
66

77
using ModelingToolkit, Symbolics, IfElse
8+
using ModelingToolkit: t_nounits as t, D_nounits as D
89
using ..Thermal: HeatPort
910
using ..Mechanical.Rotational: Flange, Support
1011
using ..Blocks: RealInput, RealOutput
1112

12-
@parameters t
13-
D = Differential(t)
14-
1513
export Pin, OnePort
1614
include("utils.jl")
1715

src/Hydraulic/IsothermalCompressible/IsothermalCompressible.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,13 @@ Library to model iso-thermal compressible liquid fluid flow
44
module IsothermalCompressible
55

66
using ModelingToolkit, Symbolics
7+
using ModelingToolkit: t_nounits as t, D_nounits as D
78

89
using ...Blocks: RealInput, RealOutput
910
using ...Mechanical.Translational: MechanicalPort, Mass
1011

1112
using IfElse: ifelse
1213

13-
@parameters t
14-
D = Differential(t)
15-
1614
export HydraulicPort, HydraulicFluid
1715
include("utils.jl")
1816

src/Magnetic/FluxTubes/FluxTubes.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
module FluxTubes
22
using ModelingToolkit
3+
using ModelingToolkit: t_nounits as t, D_nounits as D
34
using ...Electrical: Pin
45

5-
@parameters t
6-
D = Differential(t)
7-
86
export PositiveMagneticPort, NegativeMagneticPort, TwoPort
97
include("utils.jl")
108

src/Mechanical/MultiBody2D/MultiBody2D.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
module MultiBody2D
22

33
using ModelingToolkit, Symbolics, IfElse
4+
using ModelingToolkit: t_nounits as t, D_nounits as D
45
using ..TranslationalPosition
56

6-
@parameters t
7-
D = Differential(t)
8-
97
export Link
108
include("components.jl")
119

src/Mechanical/Rotational/Rotational.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@ Library to model 1-dimensional, rotational mechanical systems
44
module Rotational
55

66
using ModelingToolkit, Symbolics, IfElse
7+
using ModelingToolkit: t_nounits as t, D_nounits as D
78
using ...Blocks: RealInput, RealOutput
89
import ...@symcheck
910

10-
@parameters t
11-
D = Differential(t)
12-
1311
export Flange, Support
1412
include("utils.jl")
1513

src/Mechanical/Translational/Translational.jl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,11 @@ Library to model 1-dimensional, translational mechanical systems
44
module Translational
55

66
using ModelingToolkit, Symbolics
7-
using ModelingToolkit: getdefault
7+
using ModelingToolkit: getdefault, t_nounits as t, D_nounits as D
88

99
using ModelingToolkitStandardLibrary.Blocks: RealInput, RealOutput
1010
using IfElse: ifelse
1111

12-
@parameters t
13-
D = Differential(t)
14-
1512
export MechanicalPort
1613
include("utils.jl")
1714

src/Mechanical/TranslationalModelica/TranslationalModelica.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@ Library to model 1-dimensional, translational mechanical components.
44
module TranslationalModelica
55

66
using ModelingToolkit, Symbolics, IfElse
7+
using ModelingToolkit: t_nounits as t, D_nounits as D
78
using ...Blocks: RealInput, RealOutput
89

9-
@parameters t
10-
D = Differential(t)
11-
1210
export Flange
1311
include("utils.jl")
1412

src/Mechanical/TranslationalPosition/TranslationalPosition.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@ Library to model 1-dimensional, translational mechanical components.
44
module TranslationalPosition
55

66
using ModelingToolkit, Symbolics, IfElse
7+
using ModelingToolkit: t_nounits as t, D_nounits as D
78
using ...Blocks: RealInput, RealOutput
89

9-
@parameters t
10-
D = Differential(t)
11-
1210
export Flange
1311
include("utils.jl")
1412

src/Thermal/Thermal.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@ Library of thermal system components to model heat transfer.
33
"""
44
module Thermal
55
using ModelingToolkit, Symbolics, IfElse
6+
using ModelingToolkit: t_nounits as t, D_nounits as D
67
using ...Blocks: RealInput, RealOutput
78

8-
@parameters t
9-
D = Differential(t)
10-
119
export HeatPort, Element1D
1210
include("utils.jl")
1311

test/Blocks/continuous.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
using ModelingToolkit, ModelingToolkitStandardLibrary, OrdinaryDiffEq
22
using ModelingToolkitStandardLibrary.Blocks
3+
using ModelingToolkit: t_nounits as t
34
using OrdinaryDiffEq: ReturnCode.Success
45
using Test
56

6-
@parameters t
7-
87
#=
98
Testing strategy:
109
The general strategy is to test systems using simple inputs where the solution

test/Blocks/math.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
using ModelingToolkitStandardLibrary.Blocks
22
using ModelingToolkit, OrdinaryDiffEq, Test
33
using ModelingToolkitStandardLibrary.Blocks: _clamp, _dead_zone
4-
using ModelingToolkit: inputs, unbound_inputs, bound_inputs
4+
using ModelingToolkit: inputs, unbound_inputs, bound_inputs, t_nounits as t
55
using OrdinaryDiffEq: ReturnCode.Success
66

7-
@parameters t
8-
97
@testset "Gain" begin
108
@named c = Constant(; k = 1)
119
@named gain = Gain(; k = 1)

test/Blocks/nonlinear.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
using ModelingToolkit, OrdinaryDiffEq
22
using ModelingToolkitStandardLibrary.Blocks
3+
using ModelingToolkit: t_nounits as t
34
using ModelingToolkitStandardLibrary.Blocks: _clamp, _dead_zone
45
using OrdinaryDiffEq: ReturnCode.Success
56

6-
@parameters t
7-
87
@testset "Limiter" begin
98
@testset "Constant" begin
109
@named c = Constant(; k = 1)

test/Blocks/sources.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
using ModelingToolkit, ModelingToolkitStandardLibrary, OrdinaryDiffEq
22
using ModelingToolkitStandardLibrary.Blocks
3+
using ModelingToolkit: t_nounits as t, D_nounits as D
34
using ModelingToolkitStandardLibrary.Blocks: smooth_sin, smooth_cos, smooth_damped_sin,
45
smooth_square, smooth_step, smooth_ramp,
56
smooth_triangular, triangular, square
67
using OrdinaryDiffEq: ReturnCode.Success
78

8-
@parameters t
9-
D = Differential(t)
10-
119
@testset "Constant" begin
1210
@named src = Constant(k = 2)
1311
@named int = Integrator()

test/Blocks/test_analysis_points.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@ using Test, LinearAlgebra
22
using ModelingToolkit
33
using ModelingToolkitStandardLibrary.Blocks
44
using OrdinaryDiffEq
5-
using ModelingToolkit: get_eqs, vars, @set!, get_iv
5+
using ModelingToolkit: get_eqs, vars, @set!, t_nounits as t
66
using ControlSystemsBase
77

88
@named P = FirstOrder(k = 1, T = 1)
99
@named C = Gain(; k = -1)
10-
t = ModelingToolkit.get_iv(P)
1110

1211
@test_logs (:warn,) (:warn,) connect(P.input, :bad_connection, C.output)
1312

test/Electrical/analog.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using ModelingToolkitStandardLibrary.Electrical, ModelingToolkit, OrdinaryDiffEq, Test
2+
using ModelingToolkit: t_nounits as t
23
using ModelingToolkitStandardLibrary.Blocks: Step,
34
Constant, Sine, Cosine, ExpSine, Ramp,
45
Square, Triangular
@@ -7,8 +8,6 @@ using OrdinaryDiffEq: ReturnCode.Success
78

89
# using Plots
910

10-
@parameters t
11-
1211
@testset "sensors" begin
1312
@named source = Sine(offset = 1, amplitude = 10, frequency = 5)
1413
@named voltage = Voltage()

test/Electrical/digital.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ end
9696

9797
#=
9898
99-
@parameters t
100-
10199
@named set1 = Set()
102100
@named reset1 = Reset()
103101
@named set2 = Set()

test/Hydraulic/isothermal_compressible.jl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
using ModelingToolkit, OrdinaryDiffEq, Test
2+
using ModelingToolkit: t_nounits as t, D_nounits as D
23
import ModelingToolkitStandardLibrary.Hydraulic.IsothermalCompressible as IC
34
import ModelingToolkitStandardLibrary.Blocks as B
45
import ModelingToolkitStandardLibrary.Mechanical.Translational as T
56

67
using ModelingToolkitStandardLibrary.Blocks: Parameter
78

8-
@parameters t
9-
D = Differential(t)
10-
119
NEWTON = NLNewton(check_div = false, always_new = true, max_iter = 100, relax = 9 // 10)
1210

1311
@testset "Fluid Domain and Tube" begin
@@ -195,8 +193,6 @@ end
195193

196194
@testset "Actuator System" begin
197195
function System(use_input, f; name)
198-
@parameters t
199-
200196
pars = @parameters begin
201197
p_s = 200e5
202198
p_r = 5e5

test/Magnetic/magnetic.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ import ModelingToolkitStandardLibrary.Electrical
44
import ModelingToolkitStandardLibrary.Blocks
55
import ModelingToolkitStandardLibrary.Magnetic
66
using ModelingToolkit, OrdinaryDiffEq, Test
7+
using ModelingToolkit: t_nounits as t
78
using OrdinaryDiffEq: ReturnCode.Success
89
# using Plots
910

10-
@parameters t
11-
1211
@testset "Inductor" begin
1312
mu_air = 1
1413
l_air = 0.0001

test/Mechanical/multibody.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
using ModelingToolkit
2+
using ModelingToolkit: t_nounits as t
23
using ModelingToolkitStandardLibrary.Mechanical.MultiBody2D
34
using ModelingToolkitStandardLibrary.Mechanical.TranslationalPosition
45
using OrdinaryDiffEq
56
# using Setfield
67
using Test
78

8-
@parameters t
9-
109
@named link1 = Link(; m = 1, l = 10, I = 84, g = -9.807)
1110
@named link2 = Link(; m = 1, l = 10, I = 84, g = -9.807, x1_0 = 10)
1211
@named cart = Mass(; m = 1, s = 0)

test/Mechanical/rotational.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
using ModelingToolkitStandardLibrary.Mechanical.Rotational,
22
ModelingToolkit, OrdinaryDiffEq,
33
Test
4+
using ModelingToolkit: t_nounits as t, D_nounits as D
45
import ModelingToolkitStandardLibrary.Blocks
56
using OrdinaryDiffEq: ReturnCode.Success
67

78
# using Plots
89

9-
@parameters t
10-
D = Differential(t)
11-
1210
@testset "two inertias" begin
1311
@named fixed = Fixed()
1412
@named inertia1 = Inertia(J = 2) # this one is fixed

test/Mechanical/translational.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
using ModelingToolkit, OrdinaryDiffEq, Test
2+
using ModelingToolkit: t_nounits as t, D_nounits as D
23

34
using ModelingToolkitStandardLibrary.Blocks
45
import ModelingToolkitStandardLibrary.Mechanical.Translational as TV
56
import ModelingToolkitStandardLibrary.Mechanical.TranslationalPosition as TP
67

7-
@parameters t
8-
D = Differential(t)
9-
108
@testset "Free" begin
119
function System(; name)
1210
systems = @named begin

test/Mechanical/translational_modelica.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
using ModelingToolkit, OrdinaryDiffEq, Test
2+
using ModelingToolkit: t_nounits as t, D_nounits as D
23

34
using ModelingToolkitStandardLibrary.Blocks
45
import ModelingToolkitStandardLibrary.Mechanical.TranslationalModelica as TP
56

6-
@parameters t
7-
D = Differential(t)
8-
97
@testset "spring damper mass fixed" begin
108
@named damper = TP.Damper(; d = 1)
119
@named spring = TP.Spring(; c = 1, s_rel0 = 1)

0 commit comments

Comments
 (0)