refactor: apply suggestions from code review

Co-authored-by: Fredrik Bagge Carlson <[email protected]>

Author: ven-k

src/Electrical/Digital/logic.jl

@@ -30,14 +30,14 @@ function Base.show(io::IO, ::MIME"text/plain", l::Logic)
     elseif Int(l) == 9
         print(io, "DC")
     else
-        print(io, "Invalid logic level")
+        print(io, "Invalid logic level: $l")
     end
 end
 
-Base.zero(l::Logic) = F0
-Base.zero(l::Type{Logic}) = F0
-Base.one(l::Logic) = F1
-Base.one(l::Type{Logic}) = F1
+Base.zero(::Logic) = F0
+Base.zero(::Type{Logic}) = F0
+Base.one(::Logic) = F1
+Base.one(::Type{Logic}) = F1
 
 # Helpers to convert 1 and 0 to their `Logic` counterparts
 function Base.convert(l::Type{Logic}, i::Number)

src/Electrical/Digital/logic_vectors.jl

@@ -24,20 +24,20 @@ end
 
 const LogicVector = Union{StdULogicVector, StdLogicVector}
 
-Base.size(l::L) where {L <: LogicVector} = size(l.logic)
+Base.size(l::LogicVector) = size(l.logic)
 
-Base.axes(l::L) where {L <: LogicVector} = axes(l.logic)
+Base.axes(l::LogicVector) = axes(l.logic)
 
-function Base.getindex(s::L,
-                       i::Int) where {L <: LogicVector}
+function Base.getindex(s::LogicVector,
+                       i::Int)
     getindex(s.logic, i)
 end
-function Base.getindex(s::L, i1::Int, i2::Int,
-                       I::Int...) where {L <: LogicVector}
+function Base.getindex(s::LogicVector, i1::Int, i2::Int,
+                       I::Int...)
     getindex(s.logic, i1, i2, I...)
 end
 
-get_logic_level(s::L) where {L <: LogicVector} = s.level
+get_logic_level(s::LogicVector) = s.level
 
 # predefined vectors
 std_ulogic = StdULogicVector([U, X, F0, F1, Z, W, L, H, DC])