Skip to content

Commit bf17f3c

Browse files
Merge pull request #226 from SciML/subpckgs
Further testing clean up to get CI green
2 parents 96ea860 + db8926a commit bf17f3c

File tree

29 files changed

+51
-52
lines changed

29 files changed

+51
-52
lines changed

.github/workflows/CI.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ jobs:
2525
- GalacticMultistartOptimization
2626
- GalacticNLopt
2727
- GalacticNOMAD
28-
- GalacticNonconvex
2928
- GalacticOptimJL
3029
- GalacticQuadDIRECT
3130
- GalacticSpeedMapping
@@ -54,4 +53,4 @@ jobs:
5453
- uses: julia-actions/julia-processcoverage@v1
5554
- uses: codecov/codecov-action@v1
5655
with:
57-
file: lcov.info
56+
file: lcov.info

lib/GalacticBBO/test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using GalacticBBO, GalacticOptim, Zygote
1+
using GalacticBBO, GalacticOptim
22
using Test
33

44
@testset "GalacticBBO.jl" begin
@@ -7,7 +7,7 @@ using Test
77
_p = [1.0, 100.0]
88
l1 = rosenbrock(x0, _p)
99

10-
optprob = OptimizationFunction(rosenbrock, GalacticOptim.AutoZygote())
10+
optprob = OptimizationFunction(rosenbrock)
1111
prob = GalacticOptim.OptimizationProblem(optprob, x0, _p, lb=[-1.0, -1.0], ub=[0.8, 0.8])
1212
sol = solve(prob, BBO_adaptive_de_rand_1_bin_radiuslimited())
1313
@test 10 * sol.minimum < l1

lib/GalacticCMAEvolutionStrategy/test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
using GalacticCMAEvolutionStrategy, GalacticOptim, ForwardDiff
1+
using GalacticCMAEvolutionStrategy, GalacticOptim
22
using Test
33

44
@testset "GalacticCMAEvolutionStrategy.jl" begin
55
rosenbrock(x, p) = (p[1] - x[1])^2 + p[2] * (x[2] - x[1]^2)^2
66
x0 = zeros(2)
77
_p = [1.0, 100.0]
88
l1 = rosenbrock(x0, _p)
9-
f = OptimizationFunction(rosenbrock, GalacticOptim.AutoForwardDiff())
9+
f = OptimizationFunction(rosenbrock)
1010
prob = OptimizationProblem(f, x0, _p, lb=[-1.0, -1.0], ub=[0.8, 0.8])
1111
sol = solve(prob, CMAEvolutionStrategyOpt())
1212
@test 10 * sol.minimum < l1

lib/GalacticEvolutionary/test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
using GalacticEvolutionary, Zygote, GalacticOptim
1+
using GalacticEvolutionary, GalacticOptim
22
using Test
33

44
@testset "GalacticEvolutionary.jl" begin
55
rosenbrock(x, p) = (p[1] - x[1])^2 + p[2] * (x[2] - x[1]^2)^2
66
x0 = zeros(2)
77
_p = [1.0, 100.0]
88
l1 = rosenbrock(x0, _p)
9-
optprob = OptimizationFunction(rosenbrock, GalacticOptim.AutoZygote())
9+
optprob = OptimizationFunction(rosenbrock)
1010
prob = GalacticOptim.OptimizationProblem(optprob, x0, _p)
1111
sol = solve(prob, CMAES=40, λ=100), abstol=1e-15)
1212
@test 10 * sol.minimum < l1

lib/GalacticFlux/Project.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
1414
julia = "1"
1515

1616
[extras]
17+
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
1718
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
1819

1920
[targets]
20-
test = ["Test"]
21+
test = ["ForwardDiff","Test"]

lib/GalacticFlux/test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using GalacticFlux, GalacticOptim
1+
using GalacticFlux, GalacticOptim, ForwardDiff
22
using Test
33

44
@testset "GalacticFlux.jl" begin

lib/GalacticGCMAES/Project.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ GalacticOptim = "a75be94c-b780-496d-a8a9-0878b188d577"
1111
julia = "1"
1212

1313
[extras]
14+
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
1415
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
1516

1617
[targets]
17-
test = ["Test"]
18+
test = ["ForwardDiff", "Test"]

lib/GalacticMOI/Project.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,15 @@ version = "0.1.0"
66
[deps]
77
GalacticOptim = "a75be94c-b780-496d-a8a9-0878b188d577"
88
MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
9-
NLopt = "76087f3c-5699-56af-9a33-bf431cd00edd"
109

1110
[compat]
1211
julia = "1"
1312

1413
[extras]
1514
Ipopt = "b6b21f68-93f8-5de0-b562-5493be1d77c9"
15+
NLopt = "76087f3c-5699-56af-9a33-bf431cd00edd"
1616
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
17+
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
1718

1819
[targets]
19-
test = ["Test"]
20+
test = ["Ipopt", "NLopt", "Test", "Zygote"]

lib/GalacticMetaheuristics/test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
using GalacticMetaheuristics, GalacticOptim, Zygote
1+
using GalacticMetaheuristics, GalacticOptim
22
using Test
33

44
@testset "GalacticMetaheuristics.jl" begin
55
rosenbrock(x, p) = (p[1] - x[1])^2 + p[2] * (x[2] - x[1]^2)^2
66
x0 = zeros(2)
77
_p = [1.0, 100.0]
88
l1 = rosenbrock(x0, _p)
9-
optprob = OptimizationFunction(rosenbrock, GalacticOptim.AutoZygote())
9+
optprob = OptimizationFunction(rosenbrock)
1010
prob = GalacticOptim.OptimizationProblem(optprob, x0, _p, lb=[-1.0, -1.0], ub=[1.5, 1.5])
1111
sol = solve(prob, ECA())
1212
@test 10 * sol.minimum < l1

lib/GalacticMultistartOptimization/Project.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ MultistartOptimization = "3933049c-43be-478e-a8bb-6e0f7fd53575"
1111
julia = "1"
1212

1313
[extras]
14-
NLopt = "76087f3c-5699-56af-9a33-bf431cd00edd"
14+
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
15+
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
1516
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
1617

1718
[targets]
18-
test = ["Test"]
19+
test = ["ForwardDiff", "Pkg", "Test"]
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
using GalacticMultistartOptimization, GalacticOptim, ForwardDiff
1+
using Pkg; Pkg.develop(path=joinpath(@__DIR__,"../../","GalacticNLopt"));
2+
using GalacticMultistartOptimization, GalacticOptim, ForwardDiff, GalacticNLopt
23
using Test
34

45
@testset "GalacticMultistartOptimization.jl" begin
@@ -8,6 +9,6 @@ using Test
89
l1 = rosenbrock(x0, _p)
910
f = OptimizationFunction(rosenbrock, GalacticOptim.AutoForwardDiff())
1011
prob = GalacticOptim.OptimizationProblem(f, x0, _p, lb=[-1.0, -1.0], ub=[1.5, 1.5])
11-
sol = solve(prob, MultistartOptimization.TikTak(100), NLopt.LD_LBFGS())
12+
sol = solve(prob, GalacticMultistartOptimization.TikTak(100), GalacticNLopt.Opt(:LD_LBFGS, 2))
1213
@test 10 * sol.minimum < l1
1314
end

lib/GalacticNLopt/Project.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ julia = "1"
1313

1414
[extras]
1515
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
16+
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
1617

1718
[targets]
18-
test = ["Test"]
19+
test = ["Test", "Zygote"]

lib/GalacticNonconvex/Project.toml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,19 @@ NonconvexBayesian = "fb352abc-de7b-48de-9ebd-665b54b5d9b3"
1111
NonconvexIpopt = "bf347577-a06d-49ad-a669-8c0e005493b8"
1212
NonconvexJuniper = "611adb69-ebe7-45d0-83f5-90aabba2c123"
1313
NonconvexMMA = "d3d89cbb-4ecd-4604-818d-8d1ff343e4da"
14-
NonconvexMultistart = "11b12826-7e46-4acf-9706-be0a67f2add7"
1514
NonconvexNLopt = "b43a31b8-ff9b-442d-8e31-c163daa8ab75"
1615
NonconvexPavito = "75d5b151-dcdf-4236-8ef5-9c4e63ef33e2"
1716
NonconvexPercival = "4296f080-e499-44ba-a02c-ae40015c44d5"
1817
NonconvexSearch = "75732972-a7cd-4375-b200-958e0814350d"
1918

2019
[compat]
2120
julia = "1"
21+
NonconvexIpopt = "0.1.4"
2222

2323
[extras]
24+
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
2425
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
26+
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
2527

2628
[targets]
27-
test = ["Test"]
29+
test = ["Pkg", "Test", "Zygote"]

lib/GalacticNonconvex/src/GalacticNonconvex.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ include("nonconvex_juniper.jl")
88
include("nonconvex_ipopt.jl")
99
include("nonconvex_nlopt.jl")
1010
include("nonconvex_mma.jl")
11-
include("nonconvex_multistart.jl")
11+
# include("nonconvex_multistart.jl")
1212
include("nonconvex_percival.jl")
1313
include("nonconvex_search.jl")
1414

lib/GalacticNonconvex/src/nonconvex_bayesian.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,3 @@ function _create_options(opt::NonconvexBayesian.BayesOptAlg;
5050
end
5151

5252
check_optimizer_backend(opt::NonconvexBayesian.BayesOptAlg) = false
53-
54-
include("nonconvex.jl")

lib/GalacticNonconvex/src/nonconvex_ipopt.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,3 @@ function _create_options(opt::NonconvexIpopt.IpoptAlg;
5252
end
5353

5454
check_optimizer_backend(opt::NonconvexIpopt.IpoptAlg) = false
55-
56-
include("nonconvex.jl")

lib/GalacticNonconvex/src/nonconvex_juniper.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,3 @@ function _create_options(opt::NonconvexJuniper.JuniperIpoptAlg;
4545
end
4646

4747
check_optimizer_backend(opt::NonconvexJuniper.JuniperIpoptAlg) = false
48-
49-
include("nonconvex.jl")

lib/GalacticNonconvex/src/nonconvex_mma.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,5 +62,3 @@ function _create_options(opt::Union{NonconvexMMA.MMA02, NonconvexMMA.MMA87};
6262
end
6363

6464
check_optimizer_backend(opt::Union{NonconvexMMA.MMA02, NonconvexMMA.MMA87}) = false
65-
66-
include("nonconvex.jl")

lib/GalacticNonconvex/src/nonconvex_multistart.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,3 @@ function _create_options(opt::NonconvexMultistart.HyperoptAlg;
5959
end
6060

6161
check_optimizer_backend(opt::NonconvexMultistart.HyperoptAlg) = false
62-
63-
include("nonconvex.jl")

lib/GalacticNonconvex/src/nonconvex_nlopt.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,3 @@ function _create_options(opt::NonconvexNLopt.NLoptAlg;
5050
end
5151

5252
check_optimizer_backend(opt::NonconvexNLopt.NLoptAlg) = false
53-
54-
include("nonconvex.jl")

lib/GalacticNonconvex/src/nonconvex_pavito.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,3 @@ function _create_options(opt::NonconvexPavito.PavitoIpoptCbcAlg;
4545
end
4646

4747
check_optimizer_backend(opt::NonconvexPavito.PavitoIpoptCbcAlg) = false
48-
49-
include("nonconvex.jl")

lib/GalacticNonconvex/src/nonconvex_percival.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,3 @@ function _create_options(opt::NonconvexPercival.AugLag;
5151
end
5252

5353
check_optimizer_backend(opt::NonconvexPercival.AugLag) = false
54-
55-
include("nonconvex.jl")

lib/GalacticNonconvex/src/nonconvex_search.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,3 @@ function _create_options(opt::Union{NonconvexSearch.MTSAlg, NonconvexSearch.LS1A
5050
end
5151

5252
check_optimizer_backend(opt::Union{NonconvexSearch.MTSAlg, NonconvexSearch.LS1Alg}) = true
53-
54-
include("nonconvex.jl")

lib/GalacticNonconvex/test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using GalacticNonconvex, GalacticOptim, Zygote
1+
using GalacticNonconvex, GalacticOptim, Zygote, Pkg
22
using Test
33

44
@testset "GalacticNonconvex.jl" begin

lib/GalacticOptimJL/Project.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ julia = "1"
1313

1414
[extras]
1515
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
16+
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
1617
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
1718
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
1819

1920
[targets]
20-
test = ["Test"]
21+
test = ["ForwardDiff", "Random", "Test", "Zygote"]

lib/GalacticQuadDIRECT/Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ version = "0.1.0"
55

66
[deps]
77
GalacticOptim = "a75be94c-b780-496d-a8a9-0878b188d577"
8-
QuadDIRECT = "dae52e8d-d666-5120-a592-9e15c33b8d7a"
98

109
[compat]
1110
julia = "1"
1211

1312
[extras]
13+
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
1414
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
1515

1616
[targets]
17-
test = ["Test"]
17+
test = ["Pkg", "Test"]

lib/GalacticQuadDIRECT/test/runtests.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using Pkg; Pkg.develop(url="https://github.com/timholy/QuadDIRECT.jl.git");
12
using GalacticQuadDIRECT, GalacticOptim
23
using Test
34

lib/GalacticSpeedMapping/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
1515
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
1616

1717
[targets]
18-
test = ["Test"]
18+
test = ["ForwardDiff", "Test"]

test/runtests.jl

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,25 @@ end
1818
if GROUP == "All" || GROUP == "Core"
1919
dev_subpkg("GalacticOptimJL")
2020
dev_subpkg("GalacticFlux")
21-
@safetestset "AD Tests" begin include("ADtests.jl") end
22-
@safetestset "Mini batching" begin include("minibatch.jl") end
23-
@safetestset "DiffEqFlux" begin include("diffeqfluxtests.jl") end
21+
@safetestset "AD Tests" begin
22+
include("ADtests.jl")
23+
end
24+
@safetestset "Mini batching" begin
25+
include("minibatch.jl")
26+
end
27+
@safetestset "DiffEqFlux" begin
28+
include("diffeqfluxtests.jl")
29+
end
2430
elseif GROUP == "GPU"
2531
dev_subpkg("GalacticOptimJL")
2632
dev_subpkg("GalacticFlux")
2733
activate_downstream_env()
28-
@safetestset "DiffEqFlux GPU" begin include("downstream/gpu_neural_ode.jl") end
34+
@safetestset "DiffEqFlux GPU" begin
35+
include("downstream/gpu_neural_ode.jl")
36+
end
2937
else
38+
dev_subpkg(GROUP)
3039
subpkg_path = joinpath(dirname(@__DIR__), "lib", GROUP)
31-
Pkg.develop(PackageSpec(path=subpkg_path))
32-
include(joinpath(subpkg_path,"test","runtests.jl"))
40+
Pkg.test(PackageSpec(name=GROUP, path=subpkg_path))
3341
end
3442
end

0 commit comments

Comments
 (0)