fixup! refactor: rework timeseries parameter indexing API

Author: AayushSabharwal

src/parameter_indexing.jl

@@ -260,7 +260,6 @@ function (gpo::GetParameterObserved)(ts::Timeseries, prob, i)
     map(i) do idx
         gpo(ts, prob, idx)
     end
-    # gpo.((ts,), (prob,), i)
 end
 function (gpo::MultipleGetParameterObserved)(buffer::AbstractArray, ts::Timeseries, prob, i)
     for (buf_idx, time_idx) in zip(eachindex(buffer), i)
@@ -381,7 +380,7 @@ for (indexerTimeseriesType, timeseriesType) in [
 ]
     @eval function (mpg::MultipleParametersGetter{$indexerTimeseriesType})(
             ::$timeseriesType, prob)
-        CallWith(prob).(mpg.getters)
+        map(CallWith(prob), mpg.getters)
     end
     @eval function (mpg::MultipleParametersGetter{$indexerTimeseriesType})(
             buffer::AbstractArray, ::$timeseriesType, prob)

src/value_provider_interface.jl

@@ -36,7 +36,8 @@ function get_parameter_timeseries_collection end
 Return an indexable collection containing the value of all parameters in `valp`, with
 parameters belonging to specific timeseries updated to different values. Each element in
 `args...` contains the timeseries index as the first value, and the saved parameter values
-in that partition. Not all parameter timeseries have to be updated using this method.
+in that partition. Not all parameter timeseries have to be updated using this method. If
+an in-place update can be performed, it should be done and the modified `valp` returned.
 """
 function with_updated_parameter_timeseries_values end