Skip to content

Fetch links in the page while parsing html #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2024
Merged

Fetch links in the page while parsing html #217

merged 1 commit into from
May 11, 2024

Conversation

mayurdb
Copy link
Contributor

@mayurdb mayurdb commented May 11, 2024

Commit f8ce3d5 was reverted.

  • While changing the target, looks like one of the import was missed. That is now fixed
  • For the links within the baseurl, only absolute links were getting retrieved. Now added urlJoin to fetch complete navigable urls: /projects/rotary-pendulum-rl/ -> https://perinim.github.io/projects/rotary-pendulum-rl/
  • Moved the logic to fetch urls to the utils

@VinciGit00 VinciGit00 merged commit b752499 into ScrapeGraphAI:pre/beta May 11, 2024
@mayurdb mayurdb mentioned this pull request May 11, 2024
Merged
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.11.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @dev released on @stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurdb @VinciGit00