test: fix tests for fetch node with proper mock&refactor #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.7.0-beta.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
hi, it was almost perfect and we had to change path dir, if you can it could be helpful to make the tests fr the other nodes! |
|
Sure, I'll see what I can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#354 made the tests for fetch node kinda pointless, this pr fixes that and also simplifies other tests.
BTW, line 137 in
fetch_node.pyseems a bit odd:Feels like the first
sourceshould be the content read from the source, but I've not looked other modules yet so I'm not sure. Anyway let me know if that needs fix as well @VinciGit00