Skip to content

Commit ed86437

Browse files
DANic-gitdiemol
andauthored
[helm] add support of loadBalancerIP for hub and router services (#1589)
* [helm] add support of loadBalancerIP for hub and router services * update CHANGELOG.md and bump chart version * Update charts/selenium-grid/CHANGELOG.md * Update charts/selenium-grid/Chart.yaml Co-authored-by: Diego Molina <[email protected]>
1 parent 0e8254c commit ed86437

File tree

6 files changed

+18
-1
lines changed

6 files changed

+18
-1
lines changed

charts/selenium-grid/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
All notable changes to this helm chart will be documented in this file.
44

5+
## :heavy_check_mark: 0.8.0
6+
7+
### Added
8+
- Added support of loadBalancerIP for hub and router services
9+
510
## :heavy_check_mark: 0.7.0
611

712
### Added

charts/selenium-grid/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ apiVersion: v2
22
name: selenium-grid
33
description: A Helm chart for creating a Selenium Grid Server in Kubernetes
44
type: application
5-
version: 0.7.0
5+
version: 0.8.0
66
appVersion: 4.3.0-20220706
77
icon: https://github.com/SeleniumHQ/docker-selenium/raw/trunk/logo.png

charts/selenium-grid/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ You can configure the Selenium Hub with this values:
166166
| `hub.extraEnvFrom` | `nil` | Custom environment variables for selenium taken from `configMap` or `secret`-hub |
167167
| `hub.resources` | `{}` | Resources for selenium-hub container |
168168
| `hub.serviceType` | `NodePort` | Kubernetes service type (see https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types) |
169+
| `hub.loadBalancerIP` | `nil` | Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer) |
169170
| `hub.serviceAnnotations` | `{}` | Custom annotations for Selenium Hub service |
170171

171172

@@ -185,6 +186,7 @@ If you implement selenium-grid with separate components (`isolateComponents: tru
185186
| `components.router.readinessProbe` | `See values.yaml` | Readiness probe settings |
186187
| `components.router.resources` | `{}` | Resources for router container |
187188
| `components.router.serviceType` | `NodePort` | Kubernetes service type (see https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types) |
189+
| `components.router.loadBalancerIP` | `nil` | Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer) |
188190
| `components.router.serviceAnnotations` | `{}` | Custom annotations for router service |
189191
| `components.router.tolerations` | `[]` | Tolerations for router pods |
190192
| `components.router.nodeSelector` | `{}` | Node Selector for router pods |

charts/selenium-grid/templates/hub-service.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ spec:
1717
selector:
1818
app: selenium-hub
1919
type: {{ .Values.hub.serviceType }}
20+
{{- if and (eq .Values.hub.serviceType "LoadBalancer") ( .Values.hub.loadBalancerIP ) }}
21+
loadBalancerIP: {{ .Values.hub.loadBalancerIP }}
22+
{{- end }}
2023
ports:
2124
- name: http-hub
2225
protocol: TCP

charts/selenium-grid/templates/router-service.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ spec:
1717
selector:
1818
app: selenium-router
1919
type: {{ .Values.components.router.serviceType }}
20+
{{- if and (eq .Values.components.router.serviceType "LoadBalancer") (.Values.components.router.loadBalancerIP) }}
21+
loadBalancerIP: {{ .Values.components.router.loadBalancerIP }}
22+
{{- end }}
2023
ports:
2124
- name: tcp-router
2225
protocol: TCP

charts/selenium-grid/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ components:
7171
resources: {}
7272
# Kubernetes service type (see https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types)
7373
serviceType: ClusterIP
74+
# Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer)
75+
loadBalancerIP: ""
7476
# Custom annotations for router service
7577
serviceAnnotations: {}
7678
# Tolerations for router pods
@@ -273,6 +275,8 @@ hub:
273275
resources: {}
274276
# Kubernetes service type (see https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types)
275277
serviceType: ClusterIP
278+
# Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer)
279+
loadBalancerIP: ""
276280
# Custom annotations for Selenium Hub service
277281
serviceAnnotations: {}
278282
# Tolerations for selenium-hub pods

0 commit comments

Comments
 (0)