Skip to content

Commit f61783b

Browse files
committed
Generating StandaloneDebug images from NodeDebug images, which speeds up the build and reduces duplicated config.
1 parent 225fb30 commit f61783b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ standalone_firefox: generate_standalone_firefox firefox
6161
cd ./StandaloneFirefox && docker build $(BUILD_ARGS) -t $(NAME)/standalone-firefox:$(VERSION) .
6262

6363
generate_standalone_firefox_debug:
64-
cd ./StandaloneDebug && ./generate.sh StandaloneFirefoxDebug standalone-firefox Firefox $(VERSION) $(NAMESPACE) $(AUTHORS)
64+
cd ./StandaloneDebug && ./generate.sh StandaloneFirefoxDebug node-firefox-debug Firefox $(VERSION) $(NAMESPACE) $(AUTHORS)
6565

6666
standalone_firefox_debug: generate_standalone_firefox_debug standalone_firefox
6767
cd ./StandaloneFirefoxDebug && docker build $(BUILD_ARGS) -t $(NAME)/standalone-firefox-debug:$(VERSION) .
@@ -73,7 +73,7 @@ standalone_chrome: generate_standalone_chrome chrome
7373
cd ./StandaloneChrome && docker build $(BUILD_ARGS) -t $(NAME)/standalone-chrome:$(VERSION) .
7474

7575
generate_standalone_chrome_debug:
76-
cd ./StandaloneDebug && ./generate.sh StandaloneChromeDebug standalone-chrome Chrome $(VERSION) $(NAMESPACE) $(AUTHORS)
76+
cd ./StandaloneDebug && ./generate.sh StandaloneChromeDebug node-chrome-debug Chrome $(VERSION) $(NAMESPACE) $(AUTHORS)
7777

7878
standalone_chrome_debug: generate_standalone_chrome_debug standalone_chrome
7979
cd ./StandaloneChromeDebug && docker build $(BUILD_ARGS) -t $(NAME)/standalone-chrome-debug:$(VERSION) .

StandaloneDebug/generate.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ echo "# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!" >> $FOLDER/Dockerfil
1313
echo FROM $NAMESPACE/$BASE:$VERSION >> $FOLDER/Dockerfile
1414
echo LABEL authors="$AUTHORS" >> $FOLDER/Dockerfile
1515
echo "" >> $FOLDER/Dockerfile
16-
cat ../NodeDebug/Dockerfile.txt >> $FOLDER/Dockerfile
16+
cat ../Standalone/Dockerfile.txt >> $FOLDER/Dockerfile
17+
echo EXPOSE 5900 >> $FOLDER/Dockerfile
1718

1819
cp ./entry_point.sh $FOLDER
1920

0 commit comments

Comments
 (0)