Skip to content

Configuration example for dynamic grid uses msedge instead of MicrosoftEdge #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JannisBush opened this issue May 17, 2021 · 0 comments
Closed

Comments

@JannisBush
Copy link

🐛 Bug Report

The example config.toml file in the readme for the dynamic grid setup configures the edge containers as msedge instead of the new name MicrosoftEdge. If one uses EdgeOptions() from selenium 4, one cannot directly connect to these containers (one can change browserName as a workaround`).

To Reproduce

  • Start the docker-compose-v3-dynamic-grid.yml using the config.toml from the readme.
  • Start a script using selenium 4 and EdgeOptions
  • Capability cannot be fulfilled

Expected behavior

Edge Container should successfully start/names in this repository and other selenium repositories should be consistent.

Changing {\"browserName\": \"msedge\"}" to {\"browserName\": \"MicrosoftEdge\"}" in config.toml fixes the problem.

Test script reproducing this issue

import os
from selenium import webdriver

grid_url = "http://localhost:4444/wd/hub"
def get_driver():
    return webdriver.Remote(
        command_executor=grid_url,
        options=webdriver.EdgeOptions())

try:    
    driver = get_driver()
    try:
        driver.get("https://example.com")
    except Exception as e:
        print(e)
finally:
    try:
        driver.quit()
    except Exception as e:
        print("Fatal error", e)

Environment

OS: Linux
Docker-Selenium image version: 4.0.0-beta-3
Python-selenium version: 4.0.0b3

@ghost ghost added the needs-triaging label May 17, 2021
@diemol diemol closed this as completed in 816024c May 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants