Skip to content

Add node host as a configurable variable #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2018
Merged

Add node host as a configurable variable #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb6fcbe
Add node host as a configurable env variable
ZainabSalameh Apr 15, 2018
0becda7
Add Node Host env variable
ZainabSalameh Apr 15, 2018
e7b117d
Add host as a configurable variable
ZainabSalameh Apr 15, 2018
2194148
Merge branch 'master' into patch-1
ZainabSalameh May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NodeBase/Dockerfile.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ ENV DISPLAY :99.0
ENV NODE_MAX_INSTANCES 1
# As integer, maps to "maxSession"
ENV NODE_MAX_SESSION 1
# As address, maps to "host"
ENV NODE_HOST 0.0.0.0
# As integer, maps to "port"
ENV NODE_PORT 5555
# In milliseconds, maps to "registerCycle"
Expand Down
1 change: 1 addition & 0 deletions NodeChrome/generate_config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ cat <<_EOF
],
"proxy": "org.openqa.grid.selenium.proxy.DefaultRemoteProxy",
"maxSession": $NODE_MAX_SESSION,
"host": $NODE_HOST,
"port": $NODE_PORT,
"register": true,
"registerCycle": $NODE_REGISTER_CYCLE,
Expand Down
1 change: 1 addition & 0 deletions NodeFirefox/generate_config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ cat <<_EOF
],
"proxy": "org.openqa.grid.selenium.proxy.DefaultRemoteProxy",
"maxSession": $NODE_MAX_SESSION,
"host": $NODE_HOST,
"port": $NODE_PORT,
"register": true,
"registerCycle": $NODE_REGISTER_CYCLE,
Expand Down