Skip to content

Commit 46baed7

Browse files
committed
[rb] fix tests
1 parent c5b7acc commit 46baed7

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

.github/workflows/ruby-examples.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ jobs:
9797
cd examples/ruby
9898
bundle exec rspec
9999
new_command_on_retry: |
100-
cd examples/ruby; $env:DEBUG="true"; bundle exec rspec --only-failures
100+
cd examples/ruby; $env:DEBUG="true"; bundle exec rspec --only-failures --backtrace
101101
- name: Run tests on ${{ matrix.os }}
102102
if: matrix.os != 'windows'
103103
uses: nick-invision/[email protected]
@@ -109,4 +109,4 @@ jobs:
109109
bundle exec rspec
110110
new_command_on_retry: |
111111
cd examples/ruby
112-
DEBUG=true bundle exec rspec --only-failures
112+
DEBUG=true bundle exec rspec --only-failures --backtrace

examples/ruby/spec/browsers/firefox_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
describe 'Features' do
9090
let(:driver) { start_firefox }
9191

92-
it 'installs addon', :skip => "Skipping tests until Firefox 127 is released" do
92+
it 'installs addon' do
9393
extension_file_path = File.expand_path('../spec_support/extensions/webextensions-selenium-example.xpi', __dir__)
9494

9595
driver.install_addon(extension_file_path)
@@ -99,7 +99,7 @@
9999
expect(injected.text).to eq 'Content injected by webextensions-selenium-example'
100100
end
101101

102-
it 'uninstalls addon', :skip => "Skipping tests until Firefox 127 is released" do
102+
it 'uninstalls addon' do
103103
extension_file_path = File.expand_path('../spec_support/extensions/webextensions-selenium-example.xpi', __dir__)
104104
extension_id = driver.install_addon(extension_file_path)
105105

@@ -109,7 +109,7 @@
109109
expect(driver.find_elements(id: 'webextensions-selenium-example')).to be_empty
110110
end
111111

112-
it 'installs unsigned addon', :skip => "Skipping tests until Firefox 127 is released" do
112+
it 'installs unsigned addon' do
113113
extension_dir_path = File.expand_path('../spec_support/extensions/webextensions-selenium-example/', __dir__)
114114

115115
driver.install_addon(extension_dir_path, true)

examples/ruby/spec/browsers/internet_explorer_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
driver.quit
5050
end
5151

52-
it 'adds the silent option', skip: 'This capability will be added on the release 4.22.0' do
52+
it 'adds the silent option' do
5353
@options.silent = true
5454
expect(@options.silent).to be_truthy
5555
end

examples/ruby/spec/browsers/safari_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
end
3434
end
3535

36-
RSpec.describe 'Safari Technology Preview', skip: "This test is being skipped as GitHub Actions have no support for Safari Technology Preview" do
36+
RSpec.describe 'Safari Technology Preview' do
3737
it 'sets the technology preview' do
3838
Selenium::WebDriver::Safari.technology_preview!
3939
local_driver = Selenium::WebDriver.for :safari

examples/ruby/spec/spec_helper.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,19 @@ def start_session
3333
options = Selenium::WebDriver::Chrome::Options.new
3434
options.add_argument('disable-search-engine-choice-screen')
3535
options.add_argument('--no-sandbox')
36+
options.browser_version = 'stable'
3637
@driver = Selenium::WebDriver.for(:chrome, options: options)
3738
end
3839

3940
def start_bidi_session
4041
options = Selenium::WebDriver::Chrome::Options.new(web_socket_url: true)
42+
options.browser_version = 'stable'
4143
@driver = Selenium::WebDriver.for :chrome, options: options
4244
end
4345

4446
def start_firefox
4547
options = Selenium::WebDriver::Options.firefox(timeouts: {implicit: 1500})
48+
options.browser_version = 'stable'
4649
@driver = Selenium::WebDriver.for :firefox, options: options
4750
end
4851
end

0 commit comments

Comments
 (0)