Merge pull request scala#5671 from retronym/topic/stubby-2

Avoid compiler crash with missing transitive dependencies

Author: lrytz

src/compiler/scala/tools/nsc/Global.scala

@@ -953,10 +953,11 @@ class Global(var currentSettings: Settings, var reporter: Reporter)
        definitions.isDefinitionsInitialized
     && rootMirror.isMirrorInitialized
   )
-  override def isPastTyper = (
+  override def isPastTyper = isPast(currentRun.typerPhase)
+  def isPast(phase: Phase) = (
        (curRun ne null)
     && isGlobalInitialized // defense against init order issues
-    && (globalPhase.id > currentRun.typerPhase.id)
+    && (globalPhase.id > phase.id)
   )
 
   // TODO - trim these to the absolute minimum.

src/compiler/scala/tools/nsc/backend/ScalaPrimitives.scala

@@ -446,9 +446,10 @@ abstract class ScalaPrimitives {
       inform(s"Unknown primitive method $cls.$method")
     else alts foreach (s =>
       addPrimitive(s,
-        s.info.paramTypes match {
-          case tp :: _ if code == ADD && tp =:= StringTpe => CONCAT
-          case _                                          => code
+        if (code != ADD) code
+        else exitingTyper(s.info).paramTypes match {
+          case tp :: _ if tp =:= StringTpe => CONCAT
+          case _                           => code
         }
       )
     )

src/reflect/scala/reflect/internal/Symbols.scala

@@ -809,7 +809,7 @@ trait Symbols extends api.Symbols { self: SymbolTable =>
 
     final def isDerivedValueClass =
       isClass && !hasFlag(PACKAGE | TRAIT) &&
-      info.firstParent.typeSymbol == AnyValClass && !isPrimitiveValueClass
+      !phase.erasedTypes && info.firstParent.typeSymbol == AnyValClass && !isPrimitiveValueClass
 
     final def isMethodWithExtension =
       isMethod && owner.isDerivedValueClass && !isParamAccessor && !isConstructor && !hasFlag(SUPERACCESSOR) && !isMacro && !isSpecialized

src/reflect/scala/reflect/internal/pickling/UnPickler.scala

@@ -377,7 +377,7 @@ abstract class UnPickler {
 
       def readThisType(): Type = {
         val sym = readSymbolRef() match {
-          case stub: StubSymbol => stub.setFlag(PACKAGE)
+          case stub: StubSymbol => stub.setFlag(PACKAGE | MODULE)
           case sym => sym
         }
         ThisType(sym)

test/files/run/t10171/Test.scala

@@ -0,0 +1,59 @@
+import scala.tools.partest._
+import java.io.File
+
+object Test extends StoreReporterDirectTest {
+  def code = ???
+
+  def compileCode(code: String) = {
+    val classpath = List(sys.props("partest.lib"), testOutput.path) mkString sys.props("path.separator")
+    compileString(newCompiler("-cp", classpath, "-d", testOutput.path))(code)
+  }
+
+  def library = """
+package a {
+  package b {
+    class C { class D }
+  }
+}
+package z {
+  class Base {
+    type S = String
+    def foo(s: S): a.b.C#D = null
+  }
+  class Sub extends Base {
+    def sub = "sub"
+  }
+}
+  """
+
+  def client = """
+    class Client { new z.Sub().sub }
+  """
+
+  def deleteClass(s: String) = {
+    val f = new File(testOutput.path, s + ".class")
+    assert(f.exists)
+    f.delete()
+  }
+
+  def deletePackage(s: String) = {
+    val f = new File(testOutput.path, s)
+    assert(f.exists)
+    f.delete()
+  }
+
+  def assertNoErrors(): Unit = {
+    assert(storeReporter.infos.isEmpty, storeReporter.infos.mkString("\n"))
+    storeReporter.reset()
+  }
+  def show(): Unit = {
+    compileCode(library)
+    assertNoErrors()
+    deleteClass("a/b/C$D")
+    deleteClass("a/b/C")
+    deletePackage("a/b")
+    compileCode(client)
+    assertNoErrors()
+  }
+}
+