Set process group ID in server to terminate after parent

Author: vinistock

lib/ruby_lsp/ruby_lsp_rails/runner_client.rb

@@ -66,8 +66,9 @@ def model(name)
 
       sig { void }
       def shutdown
-        send_notification("shutdown")
-        Thread.pass while @wait_thread.alive?
+        warn("Ruby LSP Rails shutting down server")
+        send_message("shutdown")
+        sleep(0.1) if @wait_thread.alive? # give the server a bit of time to shutdown
         [@stdin, @stdout, @stderr].each(&:close)
       end
 

lib/ruby_lsp/ruby_lsp_rails/server.rb

@@ -38,6 +38,11 @@ def initialize
 
       sig { void }
       def start
+        # Put this process into the same process group as the parent one, so that it gets terminated when the parent
+        # does
+        pgid = Process.getpgid(Process.getsid)
+        Process.setpgid(0, pgid)
+
         initialize_result = { result: { message: "ok" } }.to_json
         $stdout.write("Content-Length: #{initialize_result.length}\r\n\r\n#{initialize_result}")
 

test/ruby_lsp_rails/runner_client_test.rb

@@ -14,7 +14,7 @@ class RunnerClientTest < ActiveSupport::TestCase
       end
 
       teardown do
-        @client.shutdown
+        capture_subprocess_io { @client.shutdown }
         assert_predicate @client, :stopped?
       end