Merge pull request #243 from Shopify/avoid_abstract_model_lookup

Avoid inspecting schema info for abstract classes

Author: st0012

lib/ruby_lsp_rails/rack_app.rb

@@ -31,7 +31,7 @@ def call(env)
       def resolve_database_info_from_model(model_name)
         const = ActiveSupport::Inflector.safe_constantize(model_name)
 
-        if const && const < ActiveRecord::Base
+        if const && const < ActiveRecord::Base && !const.abstract_class?
           begin
             schema_file = ActiveRecord::Tasks::DatabaseTasks.schema_dump_path(const.connection.pool.db_config)
           rescue => e

test/ruby_lsp_rails/rack_app_test.rb

@@ -35,6 +35,11 @@ class RackAppTest < ActionDispatch::IntegrationTest
         assert_response(:not_found)
       end
 
+      test "GET show returns not_found if class is an abstract model" do
+        get "/ruby_lsp_rails/models/ApplicationRecord"
+        assert_response(:not_found)
+      end
+
       test "GET activate returns success to display that server is running" do
         get "/ruby_lsp_rails/activate"
         assert_response(:success)