Do not raise if response is empty

Author: vinistock

lib/ruby_lsp/ruby_lsp_rails/runner_client.rb

@@ -278,7 +278,7 @@ def read_response
           raise IncompleteMessageError unless headers
 
           content_length = headers[/Content-Length: (\d+)/i, 1].to_i
-          raise EmptyMessageError if content_length.zero?
+          return if content_length.zero?
 
           @stdout.read(content_length)
         end

test/ruby_lsp_rails/launch_test.rb

@@ -0,0 +1,27 @@
+# typed: true
+# frozen_string_literal: true
+
+require "test_helper"
+
+module RubyLsp
+  module Rails
+    class LaunchTest < ActiveSupport::TestCase
+      test "launching the client succeeds" do
+        outgoing_queue = Thread::Queue.new
+
+        client = RunnerClient.create_client(outgoing_queue)
+        refute_instance_of(NullClient, client)
+
+        first = pop_log_notification(outgoing_queue, Constant::MessageType::LOG)
+        assert_equal("Ruby LSP Rails booting server", first.params.message)
+
+        second = pop_log_notification(outgoing_queue, Constant::MessageType::LOG)
+        assert_match("Finished booting Ruby LSP Rails server", second.params.message)
+
+        client.shutdown
+        assert_predicate(client, :stopped?)
+        outgoing_queue.close
+      end
+    end
+  end
+end

test/ruby_lsp_rails/runner_client_test.rb

@@ -87,17 +87,22 @@ class RunnerClientTest < ActiveSupport::TestCase
         junk = %{\nputs "1\r\n\r\nhello"}
         File.write("test/dummy/config/application.rb", content + junk)
 
-        capture_subprocess_io do
-          outgoing_queue = Thread::Queue.new
-          client = RunnerClient.create_client(outgoing_queue)
+        outgoing_queue = Thread::Queue.new
+
+        client = RunnerClient.create_client(outgoing_queue)
+        response = client.model("User")
 
-          response = T.must(client.model("User"))
-          assert(response.key?(:columns))
+        unless response
+          log = pop_log_notification(outgoing_queue, RubyLsp::Constant::MessageType::WARNING)
+          flunk("Model returned nil: #{log.params.message}")
+        end
+
+        begin
+          assert(T.must(response).key?(:columns))
         ensure
           T.must(outgoing_queue).close
+          FileUtils.mv("test/dummy/config/application.rb.bak", "test/dummy/config/application.rb")
         end
-      ensure
-        FileUtils.mv("test/dummy/config/application.rb.bak", "test/dummy/config/application.rb")
       end
 
       test "delegate notification" do

test/test_helper.rb

@@ -48,5 +48,13 @@ def pop_result(server)
       )
       T.cast(result, RubyLsp::Result)
     end
+
+    def pop_log_notification(message_queue, type)
+      log = message_queue.pop
+      return log if log.params.type == type
+
+      log = message_queue.pop until log.params.type == type
+      log
+    end
   end
 end