Fixes for Windows

Author: andyw8

.github/workflows/ci.yml

@@ -55,4 +55,4 @@ jobs:
         run: bin/rubocop
 
       - name: Run tests
-        run: bin/rails db:setup && bin/rails db:migrate && bin/rails test
+        run: bundle exec rails db:setup && bundle exec rails db:migrate && bundle exec rails test

Gemfile

@@ -20,3 +20,4 @@ gem "tapioca", "~> 0.13", require: false, platforms: :ruby
 gem "psych", "~> 5.1", require: false
 gem "rails"
 gem "webmock"
+gem "tzinfo-data"

Gemfile.lock

@@ -266,6 +266,8 @@ GEM
     timeout (0.4.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
+    tzinfo-data (1.2024.1)
+      tzinfo (>= 1.0.0)
     unicode-display_width (2.5.0)
     webmock (3.23.0)
       addressable (>= 2.8.0)
@@ -301,6 +303,7 @@ DEPENDENCIES
   sorbet-static-and-runtime
   sqlite3 (< 2)
   tapioca (~> 0.13)
+  tzinfo-data
   webmock
 
 BUNDLED WITH

gemfiles/Gemfile-rails-main

@@ -20,3 +20,4 @@ gem "tapioca", "~> 0.11", require: false, platforms: :ruby
 gem "psych", "~> 5.1", require: false
 gem "rails", github: "rails/rails", branch: "main"
 gem "webmock"
+gem "tzinfo-data"

lib/ruby_lsp/ruby_lsp_rails/hover.rb

@@ -77,7 +77,7 @@ def generate_column_content(name)
         schema_file = model[:schema_file]
 
         @response_builder.push(
-          "[Schema](#{URI::Generic.build(scheme: "file", path: schema_file)})",
+          "[Schema](#{URI::Generic.from_path(path: schema_file)})",
           category: :links,
         ) if schema_file
 

lib/ruby_lsp/ruby_lsp_rails/runner_client.rb

@@ -46,10 +46,15 @@ def initialize
           Process.setsid
         rescue Errno::EPERM
           # If we can't set the session ID, continue
+        rescue NotImplementedError
+          # setpgrp() may be unimplemented on some platform
+          # https://github.com/Shopify/ruby-lsp-rails/issues/348
         end
 
         stdin, stdout, stderr, wait_thread = Open3.popen3(
-          "bin/rails",
+          "bundle",
+          "exec",
+          "rails",
           "runner",
           "#{__dir__}/server.rb",
           "start",

test/ruby_lsp_rails/runner_client_test.rb

@@ -54,16 +54,10 @@ class RunnerClientTest < ActiveSupport::TestCase
       end
 
       test "failing to spawn server creates a null client" do
-        FileUtils.mv("bin/rails", "bin/rails_backup")
-        File.open("bin/rails", "w") do |f|
-          f.write("foo")
-        end
-        File.chmod(0o755, "bin/rails")
-
-        # The error message is slightly different on Ubuntu, so we need to allow for that
+        FileUtils.mv("test/dummy/config/application.rb", "test/dummy/config/application.rb.bak")
         assert_output(
           "",
-          %r{Ruby LSP Rails failed to initialize server: bin/rails: (line )?1: foo:( command)? not found},
+          /Ruby LSP Rails failed to initialize server/,
         ) do
           client = RunnerClient.create_client
 
@@ -72,7 +66,7 @@ class RunnerClientTest < ActiveSupport::TestCase
           assert_predicate(client, :stopped?)
         end
       ensure
-        FileUtils.mv("bin/rails_backup", "bin/rails")
+        FileUtils.mv("test/dummy/config/application.rb.bak", "test/dummy/config/application.rb")
       end
 
       test "is resilient to extra output being printed during boot" do

test/test_helper.rb

@@ -32,7 +32,11 @@ class TestCase
     include RubyLsp::TestHelper
 
     def dummy_root
-      File.expand_path("#{__dir__}/dummy")
+      result = File.expand_path("#{__dir__}/dummy")
+      unless result[0] == "/"
+        result = result.prepend("/")
+      end
+      result
     end
   end
 end