Handle schema_dump_path being unavailable in Rails 6

Author: andyw8

lib/ruby_lsp/ruby_lsp_rails/server.rb

@@ -26,7 +26,7 @@ class Server
 
       extend T::Sig
 
-      sig { params(model_name: String).returns(T.nilable(T::Hash[Symbol, T.untyped])) }
+      sig { params(model_name: String).returns(T::Hash[Symbol, T.untyped]) }
       def resolve_database_info_from_model(model_name)
         const = ActiveSupport::Inflector.safe_constantize(model_name)
         unless const && const < ActiveRecord::Base && !const.abstract_class?
@@ -42,7 +42,9 @@ def resolve_database_info_from_model(model_name)
         }
 
         if ActiveRecord::Tasks::DatabaseTasks.respond_to?(:schema_dump_path)
-          info[:schema_file] = ActiveRecord::Tasks::DatabaseTasks.schema_dump_path(const.connection.pool.db_config)
+          info[:result][:schema_file] =
+            ActiveRecord::Tasks::DatabaseTasks.schema_dump_path(const.connection.pool.db_config)
+
         end
         info
       rescue => e

test/ruby_lsp_rails/server_test.rb

@@ -0,0 +1,17 @@
+# typed: true
+# frozen_string_literal: true
+
+require "test_helper"
+require "ruby_lsp/ruby_lsp_rails/server"
+
+require "test_helper"
+class ServerTest < ActiveSupport::TestCase
+  test "handles older Rails version which don't have `schema_dump_path`" do
+    ActiveRecord::Tasks::DatabaseTasks.send(:alias_method, :old_schema_dump_path, :schema_dump_path)
+    ActiveRecord::Tasks::DatabaseTasks.undef_method(:schema_dump_path)
+    response = RubyLsp::Rails::Server.new.resolve_database_info_from_model("User")
+    assert_nil(response.fetch(:result)[:schema_file])
+  ensure
+    ActiveRecord::Tasks::DatabaseTasks.send(:alias_method, :schema_dump_path, :old_schema_dump_path)
+  end
+end