Skip to content

Commit 7beb6d5

Browse files
authored
Merge pull request #228 from Shopify/andyw8/fix-ci
Fix CI
2 parents 86c8ba6 + 16ceb69 commit 7beb6d5

File tree

11 files changed

+1974
-1713
lines changed

11 files changed

+1974
-1713
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,32 +11,37 @@ jobs:
1111
os: [ubuntu-latest, macos-latest, windows-latest]
1212
gemfile:
1313
- Gemfile
14-
- Gemfile-rails-main
14+
- gemfiles/Gemfile-rails-main
1515
ruby: ["3.0", "3.1", "3.2", "3.3", "head"]
1616
include:
1717
- ruby: "head"
1818
experimental: true
19-
- gemfile: "Gemfile-rails-main"
19+
- gemfile: "gemfiles/Gemfile-rails-main"
2020
experimental: true
2121
exclude:
2222
- os: "windows-latest"
2323
ruby: "3.0"
24+
- Gemfile: "gemfiles/Gemfile-rails-main" # needs Ruby 3.1
25+
ruby: "3.0"
2426
runs-on: ${{ matrix.os }}
27+
env:
28+
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
2529
continue-on-error: ${{ !!matrix.experimental }}
2630
name: Ruby ${{ matrix.ruby }} on ${{ matrix.os }} with ${{matrix.gemfile}}
2731
steps:
2832
- uses: actions/checkout@v3
2933

3034
- name: Remove Gemfile.lock
31-
if: (matrix.ruby == 'head' ) || (matrix.os == 'windows-latest' && matrix.ruby == '3.1')
32-
run: "rm ${{ matrix.gemfile }}.lock
35+
if: (matrix.gemfile == 'Gemfile') && ((matrix.ruby == 'head' ) || (matrix.os == 'windows-latest' && matrix.ruby == '3.1'))
36+
run: "rm ${{ matrix.gemfile }}.lock"
3337

3438
- name: Set up Ruby
3539
uses: ruby/setup-ruby@v1
3640
with:
41+
bundler: latest
3742
ruby-version: ${{ matrix.ruby }}
3843
bundler-cache: true
39-
cache-version: 6
44+
cache-version: 7
4045

4146
- name: Check if documentation is up to date
4247
run: bundle exec rake ruby_lsp:check_docs

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ GEM
223223
rubocop (~> 1.51)
224224
rubocop-sorbet (0.7.6)
225225
rubocop (>= 0.90.0)
226-
ruby-lsp (0.13.2)
226+
ruby-lsp (0.13.3)
227227
language_server-protocol (~> 3.17.0)
228228
prism (>= 0.19.0, < 0.20)
229229
sorbet-runtime (>= 0.5.5685)

Gemfile-rails-main renamed to gemfiles/Gemfile-rails-main

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ source "https://rubygems.org"
44
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
55

66
# Specify your gem's dependencies in ruby_lsp_rails.gemspec.
7-
gemspec
7+
gemspec path: ".."
88

99
gem "puma"
1010
gem "sqlite3"

0 commit comments

Comments
 (0)