Skip to content

Commit aa5b6ba

Browse files
committed
Misc. improvements
1 parent 07a4d96 commit aa5b6ba

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

lib/ruby_lsp/ruby_lsp_rails/runner_client.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,21 +170,23 @@ def make_request(request, params = nil)
170170
read_response
171171
end
172172

173-
sig { params(request: String, params: T.nilable(T::Hash[Symbol, T.untyped])).void }
173+
# Messages expect a response back
174+
sig { overridable.params(request: String, params: T.nilable(T::Hash[Symbol, T.untyped])).void }
174175
def send_message(request, params = nil)
175176
message = { method: request }
176177
message[:params] = params if params
177178
json = message.to_json
178179

179180
@stdin.write("Content-Length: #{json.length}\r\n\r\n", json)
180181
rescue Errno::EPIPE
181-
# The server connection died
182+
$stderr.puts("Lost connection to the Rails server.")
182183
end
183184

185+
# Notifications are messages that do not expect a response
184186
sig { params(request: String, params: T.nilable(T::Hash[Symbol, T.untyped])).void }
185187
def send_notification(request, params = nil) = send_message(request, params)
186188

187-
sig { returns(T.nilable(T::Hash[Symbol, T.untyped])) }
189+
sig { overridable.returns(T.nilable(T::Hash[Symbol, T.untyped])) }
188190
def read_response
189191
headers = @stdout.gets("\r\n\r\n")
190192
raise IncompleteMessageError unless headers

0 commit comments

Comments
 (0)