wip

Author: andyw8

lib/ruby_lsp/ruby_lsp_rails/definition.rb

@@ -60,8 +60,8 @@ def on_call_node_enter(node)
 
         if Support::Callbacks::ALL.include?(message)
           handle_callback(node)
-        elsif message.match?(/^([a-z0-9_]+)(_path|_url)$/)
-          handle_route(node) # check. what about digits?
+        elsif message.match?(/^([a-zA-Z0-9_]+)(_path|_url)$/)
+          handle_route(node)
         end
       end
 
@@ -90,7 +90,6 @@ def handle_callback(node)
       def handle_route(node)
         result = @client.route_location(node.message)
 
-        # A token could match the _path or _url pattern, but not be an actual route.
         location = T.must(result).fetch(:location)
         return unless location
 

lib/ruby_lsp/ruby_lsp_rails/server.rb

@@ -22,8 +22,6 @@
 # NOTE: We should avoid printing to stderr since it causes problems. We never read the standard error pipe from the
 # client, so it will become full and eventually hang or crash. Instead, return a response with an `error` key.
 
-# ActionDispatch::Routing::Mapper.route_source_locations = true
-
 module RubyLsp
   module Rails
     class Server
@@ -85,16 +83,9 @@ def execute(request, params)
 
       sig { params(name: String).returns(T::Hash[Symbol, T.untyped]) }
       def route_location(name)
-        unless ActionDispatch::Routing::Mapper.route_source_locations
-          return {
-            result: {
-              location: nil,
-            },
-          }
-        end
-
-        key = name.match(/^([a-z_]+)(_path|_url)$/)[1]
+        key = name.match(/^([a-zA-Z0-9_]+)(_path|_url)$/)[1]
 
+        # A token could match the _path or _url pattern, but not be an actual route.
         unless ::Rails.application.routes.named_routes.key?(key)
           return {
             result: {
@@ -112,9 +103,10 @@ def route_location(name)
             },
           }
         end
+
         {
           result: {
-            location: ::Rails.root.to_s + "/" + route.source_location,
+            location: ::Rails.root.join(route.source_location),
           },
         }
       end