Skip to content

Commit f672239

Browse files
author
Aryan Soni
committed
Remove unneccesary code in definition.rb, improve docs, and update naming for callback module
1 parent fa58345 commit f672239

File tree

3 files changed

+2
-13
lines changed

3 files changed

+2
-13
lines changed

lib/ruby_lsp/ruby_lsp_rails/definition.rb

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,16 @@ module Rails
1010
# definition of the symbol under the cursor.
1111
#
1212
# Currently supported targets:
13-
# - Classes
14-
# - Modules
15-
# - Constants
16-
# - Require paths
17-
# - Methods invoked on self only
13+
# - Callbacks
1814
#
1915
# # Example
2016
#
2117
# ```ruby
22-
# require "some_gem/file" # <- Request go to definition on this string will take you to the file
23-
# Product.new # <- Request go to definition on this class name will take you to its declaration.
18+
# before_action :foo # <- Request go to definition on this symbol will take you to the method
2419
# ```
2520
class Definition
2621
extend T::Sig
2722
include Requests::Support::Common
28-
include ActiveSupportTestCaseHelper
2923
include Support::Callbacks
3024

3125
sig do

misc/definition.gif

-662 KB
Loading

test/ruby_lsp_rails/definition_test.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ module Rails
88
class DefinitionTest < ActiveSupport::TestCase
99
setup do
1010
@message_queue = Thread::Queue.new
11-
12-
# Build the Rails documents index ahead of time
13-
capture_io do
14-
Support::RailsDocumentClient.send(:search_index)
15-
end
1611
end
1712

1813
def teardown

0 commit comments

Comments
 (0)