Skip to content

Remove Gemfile.lock for Ruby head #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Remove Gemfile.lock for Ruby head #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
os: [ubuntu-latest, macos-latest, windows-latest]
gemfile:
- Gemfile
- gemfiles/Gemfile-rails-main
- Gemfile-rails-main
ruby: ["3.0", "3.1", "3.2", "3.3", "head"]
include:
- ruby: "head"
experimental: true
- gemfile: "gemfiles/Gemfile-rails-main"
- gemfile: "Gemfile-rails-main"
experimental: true
exclude:
- os: "windows-latest"
Expand All @@ -28,8 +28,8 @@ jobs:
- uses: actions/checkout@v3

- name: Remove Gemfile.lock
if: matrix.os == 'windows-latest' && matrix.ruby == '3.1'
run: rm Gemfile.lock
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was invalid previously because it was removing the wrong lockfile in cases where the gemfile was Gemfile-rails-main. It seems the gemspec entry in the Gemfile wasn't playing well with a Gemfile contained in a subdirectory, so I moved it up to the root.

if: (matrix.ruby == 'head' ) || (matrix.os == 'windows-latest' && matrix.ruby == '3.1')
run: "rm ${{ matrix.gemfile }}.lock

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand Down
0 gemfiles/Gemfile-rails-main → Gemfile-rails-main
View file
Open in desktop
File renamed without changes.