Show require and require_relative completions on quotes (#1443)

Author: vinistock

lib/ruby_lsp/listeners/completion.rb

@@ -100,8 +100,6 @@ def on_constant_path_node_enter(node)
 
       sig { params(node: Prism::CallNode).void }
       def on_call_node_enter(node)
-        return if @typechecker_enabled
-
         name = node.message
         return unless name
 
@@ -111,7 +109,7 @@ def on_call_node_enter(node)
         when "require_relative"
           complete_require_relative(node)
         else
-          complete_self_receiver_method(node, name) if self_receiver?(node)
+          complete_self_receiver_method(node, name) if !@typechecker_enabled && self_receiver?(node)
         end
       end
 
@@ -142,14 +140,17 @@ def complete_require_relative(node)
 
         origin_dir = Pathname.new(@uri.to_standardized_path).dirname
 
-        path_query = path_node_to_complete.content
+        content = path_node_to_complete.content
         # if the path is not a directory, glob all possible next characters
         # for example ../somethi| (where | is the cursor position)
         # should find files for ../somethi*/
-        path_query += "*/" unless path_query.end_with?("/")
-        path_query += "**/*.rb"
+        path_query = if content.end_with?("/") || content.empty?
+          "#{content}**/*.rb"
+        else
+          "{#{content}*/**/*.rb,**/#{content}*.rb}"
+        end
 
-        Dir.glob(path_query, base: origin_dir).sort!.each do |path|
+        Dir.glob(path_query, File::FNM_PATHNAME | File::FNM_EXTGLOB, base: origin_dir).sort!.each do |path|
           @response_builder << build_completion(
             path.delete_suffix(".rb"),
             path_node_to_complete,

lib/ruby_lsp/requests/completion.rb

@@ -34,7 +34,7 @@ class << self
         def provider
           Interface::CompletionOptions.new(
             resolve_provider: false,
-            trigger_characters: ["/"],
+            trigger_characters: ["/", "\"", "'"],
             completion_item: {
               labelDetailsSupport: true,
             },

test/requests/completion_test.rb

@@ -690,6 +690,35 @@ def test_relative_completion_command_call
     assert_equal(expected.to_json, result.to_json)
   end
 
+  def test_relative_completion_command_call_without_leading_dot
+    source = <<~RUBY
+      Kernel.require_relative "b"
+    RUBY
+
+    end_char = T.must(source.rindex('"'))
+    start_position = { line: 0, character: T.must(source.index('"')) + 1 }
+    end_position = { line: 0, character: end_char }
+
+    result = with_file_structure do |tmpdir|
+      uri = URI("file://#{tmpdir}/foo/quxx.rb")
+      document = RubyLsp::RubyDocument.new(source: source, version: 1, uri: uri)
+      @store.set(uri: uri, source: document.source, version: 1)
+      run_request(
+        method: "textDocument/completion",
+        params: { textDocument: { uri: uri.to_s }, position: { line: 0, character: end_char } },
+      )
+    end
+
+    expected = [
+      path_completion("bar", start_position, end_position),
+      path_completion("baz", start_position, end_position),
+      path_completion("support/bar", start_position, end_position),
+      path_completion("support/baz", start_position, end_position),
+    ]
+
+    assert_equal(expected.to_json, result.to_json)
+  end
+
   def test_relative_completion_with_partial_path
     prefix = "../suppo"
     source = <<~RUBY