Merge pull request #837 from Shopify/vs/fix_dependency_detector_outside_of_bundle

Prevent dependency detector from failing outside of a bundle

Author: vinistock

lib/ruby_lsp/requests/support/dependency_detector.rb

@@ -38,7 +38,10 @@ def detected_test_library
 
       sig { params(gem_pattern: Regexp).returns(T::Boolean) }
       def direct_dependency?(gem_pattern)
-        Bundler.locked_gems.dependencies.keys.grep(gem_pattern).any?
+        Bundler.with_original_env { Bundler.default_gemfile } &&
+          Bundler.locked_gems.dependencies.keys.grep(gem_pattern).any?
+      rescue Bundler::GemfileNotFound
+        false
       end
     end
   end

test/requests/support/dependency_detector_test.rb

@@ -39,5 +39,10 @@ def test_detects_rails_if_both_rails_and_minitest_are_present
 
       assert_equal("rails", DependencyDetector.detected_test_library)
     end
+
+    def test_direct_dependency_returns_false_outside_of_bundle
+      File.expects(:file?).at_least_once.returns(false)
+      refute(DependencyDetector.direct_dependency?(/^ruby-lsp/))
+    end
   end
 end