Debug

Author: vinistock

vscode/src/ruby/chruby.ts

@@ -60,7 +60,7 @@ export class Chruby extends VersionManager {
       PATH: `${path.join(gemHome, "bin")}${path.delimiter}${path.join(
         defaultGems,
         "bin",
-      )}${path.delimiter}${path.dirname(rubyUri.fsPath)}${path.delimiter}${process.env.PATH}`,
+      )}${path.delimiter}${path.dirname(rubyUri.fsPath)}${path.delimiter}${this.getProcessPath()}`,
     };
 
     return {
@@ -70,6 +70,19 @@ export class Chruby extends VersionManager {
     };
   }
 
+  protected getProcessPath() {
+    return process.env.PATH;
+  }
+
+  // Returns the full URI to the Ruby executable
+  protected async findRubyUri(rubyVersion: RubyVersion): Promise<vscode.Uri> {
+    if (/\d+\.\d+\.\d+/.exec(rubyVersion.version)) {
+      return this.findRubyUriForCompleteVersion(rubyVersion);
+    }
+
+    return this.findRubyUriWithOmittedPatch(rubyVersion);
+  }
+
   // Run the activation script using the Ruby installation we found so that we can discover gem paths
   protected async runActivationScript(rubyExecutableUri: vscode.Uri): Promise<{
     defaultGems: string;
@@ -105,15 +118,6 @@ export class Chruby extends VersionManager {
     return this.parseWithErrorHandling(result.stderr);
   }
 
-  // Returns the full URI to the Ruby executable
-  protected async findRubyUri(rubyVersion: RubyVersion): Promise<vscode.Uri> {
-    if (/\d+\.\d+\.\d+/.exec(rubyVersion.version)) {
-      return this.findRubyUriForCompleteVersion(rubyVersion);
-    }
-
-    return this.findRubyUriWithOmittedPatch(rubyVersion);
-  }
-
   private async findRubyUriWithOmittedPatch(
     rubyVersion: RubyVersion,
   ): Promise<vscode.Uri> {

vscode/src/ruby/rubyInstaller.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-process-env */
 import os from "os";
 
 import * as vscode from "vscode";
@@ -16,6 +17,12 @@ interface RubyVersion {
 //
 // If we can't find it there, then we throw an error and rely on the user to manually select where Ruby is installed.
 export class RubyInstaller extends Chruby {
+  // Environment variables are case sensitive on Windows when we access them through NodeJS. We need to ensure that
+  // we're searching through common variations, so that we don't accidentally miss the path we should inherit
+  protected getProcessPath() {
+    return process.env.Path ?? process.env.PATH ?? process.env.path;
+  }
+
   // Returns the full URI to the Ruby executable
   protected async findRubyUri(rubyVersion: RubyVersion): Promise<vscode.Uri> {
     const [major, minor, _patch] = rubyVersion.version.split(".").map(Number);

vscode/src/test/suite/ruby/rubyInstaller.test.ts

@@ -60,8 +60,7 @@ suite("RubyInstaller", () => {
     const windows = new RubyInstaller(workspaceFolder, outputChannel);
     const { env, version, yjit } = await windows.activate();
 
-    assert.match(env.GEM_PATH!, /ruby\/3\.3\.0/);
-    assert.match(env.GEM_PATH!, /lib\/ruby\/gems\/3\.3\.0/);
+    assert.match(env.GEM_PATH!, /lib\\ruby\\gems\\3\.3\.0/);
     assert.strictEqual(version, RUBY_VERSION);
     assert.notStrictEqual(yjit, undefined);
 
@@ -90,8 +89,7 @@ suite("RubyInstaller", () => {
     const windows = new RubyInstaller(workspaceFolder, outputChannel);
     const { env, version, yjit } = await windows.activate();
 
-    assert.match(env.GEM_PATH!, /ruby\/3\.3\.0/);
-    assert.match(env.GEM_PATH!, /lib\/ruby\/gems\/3\.3\.0/);
+    assert.match(env.GEM_PATH!, /lib\\ruby\\gems\\3\.3\.0/);
     assert.strictEqual(version, RUBY_VERSION);
     assert.notStrictEqual(yjit, undefined);