Skip to content

Commit 7f75f45

Browse files
authored
Merge pull request #636 from Shopify/vs/fix_benchmark_exit_status
Fix benchmark exit status
2 parents 018b07a + fe4697a commit 7f75f45

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/workflows/benchmark.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,8 @@ jobs:
5858
# Fail the job based on the benchmark output
5959
- name: Finalize job
6060
run: |
61-
REPORT="${{ steps.benchmark.outputs.REPORT }}"
62-
IS_SLOWER=$(grep "At least one benchmark is slower than the main branch" <<< "$REPORT")
63-
IS_MISSING=$(grep "Missing benchmarks" <<< "$REPORT")
64-
65-
if [[ $IS_SLOWER || $IS_MISSING ]]; then
61+
report="${{ steps.benchmark.outputs.REPORT }}"
62+
if [[ "$report" == *"At least one benchmark is slower than the main branch"* ]] || [[ "$report" == *"Missing benchmarks"* ]]; then
6663
exit 1
6764
else
6865
exit 0

0 commit comments

Comments
 (0)