Skip to content

Commit a66750e

Browse files
authored
Merge pull request #759 from abhiroopdutta/abhiroopdutta/issue754
Fix incorrect folding for `else`
2 parents 7886c31 + a7f5152 commit a66750e

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

lib/ruby_lsp/requests/folding_ranges.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ class FoldingRanges < BaseRequest
2727
SyntaxTree::For,
2828
SyntaxTree::HashLiteral,
2929
SyntaxTree::Heredoc,
30-
SyntaxTree::IfNode,
3130
SyntaxTree::ModuleDeclaration,
3231
SyntaxTree::SClass,
3332
SyntaxTree::UnlessNode,
@@ -42,6 +41,7 @@ class FoldingRanges < BaseRequest
4241

4342
NODES_WITH_STATEMENTS = T.let(
4443
[
44+
SyntaxTree::IfNode,
4545
SyntaxTree::Elsif,
4646
SyntaxTree::In,
4747
SyntaxTree::Rescue,
@@ -52,6 +52,7 @@ class FoldingRanges < BaseRequest
5252

5353
StatementNode = T.type_alias do
5454
T.any(
55+
SyntaxTree::IfNode,
5556
SyntaxTree::Elsif,
5657
SyntaxTree::In,
5758
SyntaxTree::Rescue,

test/expectations/folding_ranges/call_chained.exp.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
},
88
{
99
"startLine": 2,
10-
"endLine": 5,
10+
"endLine": 3,
1111
"kind": "region"
1212
},
1313
{

test/expectations/folding_ranges/if_elsif_else.exp.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"result": [
33
{
44
"startLine": 0,
5-
"endLine": 5,
5+
"endLine": 1,
66
"kind": "region"
77
},
88
{
Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
{
22
"result": [
3-
{
4-
"startLine": 0,
5-
"endLine": 2,
6-
"kind": "region"
7-
}
83
]
94
}

0 commit comments

Comments
 (0)